December 2017 - Libguestfs - Libguestfs List Archives

[PATCH v2] launch: add support for autodetection of appliance image format

by Pavel Butsykin

This feature allows you to use different image formats for the fixed appliance. The raw format is used by default. Signed-off-by: Pavel Butsykin <pbutsykin(a)virtuozzo.com> --- lib/launch-direct.c | 2 ++ lib/launch-libvirt.c | 19 ++++++++++++------- m4/guestfs_appliance.m4 | 11 +++++++++++ 3 files changed, 25 insertions(+), 7 deletions(-) diff --git a/lib/launch-direct.c b/lib/launch-direct.c index 0be662e25..b9b54857a 100644 --- a/lib/launch-direct.c +++ b/lib/launch-direct.c @@ -592,7 +592,9 @@ launch_direct (guestfs_h *g, void *datav, const char *arg) append_list ("id=appliance"); append_list ("cache=unsafe"); append_list ("if=none"); +#ifndef APPLIANCE_FMT_AUTO append_list ("format=raw"); +#endif } end_list (); start_list ("-device") { append_list ("scsi-hd"); diff --git a/lib/launch-libvirt.c b/lib/launch-libvirt.c index 4adb2cfb3..030ea6911 100644 --- a/lib/launch-libvirt.c +++ b/lib/launch-libvirt.c @@ -212,9 +212,10 @@ get_source_format_or_autodetect (guestfs_h *g, struct drive *drv) /** * Create a qcow2 format overlay, with the given C<backing_drive> - * (file). The C<format> parameter, which must be non-NULL, is the - * backing file format. This is used to create the appliance overlay, - * and also for read-only drives. + * (file). The C<format> parameter is the backing file format. + * The C<format> parameter can be NULL, in this case the backing + * format will be determined automatically. This is used to create + * the appliance overlay, and also for read-only drives. */ static char * make_qcow2_overlay (guestfs_h *g, const char *backing_drive, @@ -223,8 +224,6 @@ make_qcow2_overlay (guestfs_h *g, const char *backing_drive, char *overlay; struct guestfs_disk_create_argv optargs; - assert (format != NULL); - if (guestfs_int_lazy_make_tmpdir (g) == -1) return NULL; @@ -232,8 +231,10 @@ make_qcow2_overlay (guestfs_h *g, const char *backing_drive, optargs.bitmask = GUESTFS_DISK_CREATE_BACKINGFILE_BITMASK; optargs.backingfile = backing_drive; - optargs.bitmask |= GUESTFS_DISK_CREATE_BACKINGFORMAT_BITMASK; - optargs.backingformat = format; + if (format) { + optargs.bitmask |= GUESTFS_DISK_CREATE_BACKINGFORMAT_BITMASK; + optargs.backingformat = format; + } if (guestfs_disk_create_argv (g, overlay, "qcow2", -1, &optargs) == -1) { free (overlay); @@ -461,7 +462,11 @@ launch_libvirt (guestfs_h *g, void *datav, const char *libvirt_uri) /* Note that appliance can be NULL if using the old-style appliance. */ if (appliance) { +#ifdef APPLIANCE_FMT_AUTO + params.appliance_overlay = make_qcow2_overlay (g, appliance, NULL); +#else params.appliance_overlay = make_qcow2_overlay (g, appliance, "raw"); +#endif if (!params.appliance_overlay) goto cleanup; } diff --git a/m4/guestfs_appliance.m4 b/m4/guestfs_appliance.m4 index 81c43879f..4e1ec8135 100644 --- a/m4/guestfs_appliance.m4 +++ b/m4/guestfs_appliance.m4 @@ -139,3 +139,14 @@ AC_SUBST([GUESTFS_DEFAULT_PATH]) AC_DEFINE_UNQUOTED([GUESTFS_DEFAULT_PATH], ["$GUESTFS_DEFAULT_PATH"], [Define guestfs default path.]) + +AC_ARG_ENABLE([appliance-fmt-auto], + [AS_HELP_STRING([--enable-appliance-fmt-auto], + [enable autodetection of appliance image format @<:@default=no@:>@])], + [ENABLE_APPLIANCE_FMT_AUTO="$enableval"], + [ENABLE_APPLIANCE_FMT_AUTO=no]) + +if test "x$ENABLE_APPLIANCE_FMT_AUTO" = "xyes"; then + AC_DEFINE([APPLIANCE_FMT_AUTO], [1], + [Define to 1 if enabled autodetection of appliance image format.]) +fi -- 2.13.0

6 years

2
4
0 / 0

[PATCH v2] lib/info: Remove /dev/fd hacking and pass a true filename

by Richard W.M. Jones

v1 posted here: https://www.redhat.com/archives/libguestfs/2017-December/msg00050.html v2 fixes the tests by rewriting relative paths as ./filename (so that filenames like "file:foo" work).

8 years, 1 month

2
3
0 / 0

[PATCH] configure: Don't define _FORTIFY_SOURCE.

by Richard W.M. Jones

We routinely test the upstream code by running everything under valgrind, and in any case _FORTIFY_SOURCE is usually defined by downstream Linux distros and we can leave the optimization vs safety decision to them. See this bug: https://bugs.gentoo.org/640494 --- m4/guestfs-c.m4 | 6 ------ 1 file changed, 6 deletions(-) diff --git a/m4/guestfs-c.m4 b/m4/guestfs-c.m4 index 932b6de73..3e8642675 100644 --- a/m4/guestfs-c.m4 +++ b/m4/guestfs-c.m4 @@ -119,12 +119,6 @@ AC_SUBST([NO_UM_CFLAGS]) AC_DEFINE([lint], [1], [Define to 1 if the compiler is checking for lint.]) AC_DEFINE([GNULIB_PORTCHECK], [1], [Enable some gnulib portability checks.]) -AH_VERBATIM([FORTIFY_SOURCE],[ -/* Enable compile-time and run-time bounds-checking, and some warnings. */ -#if __OPTIMIZE__ && (! defined (_FORTIFY_SOURCE) || _FORTIFY_SOURCE < 2) -# undef _FORTIFY_SOURCE -# define _FORTIFY_SOURCE 2 -#endif]) AC_C_PROTOTYPES test "x$U" != "x" && AC_MSG_ERROR([Compiler not ANSI compliant]) -- 2.13.2

8 years, 1 month

2
1
0 / 0

Re: [Libguestfs] virt-customize error

by Pino Toscano

Hi, please keep the replies on the list ... On Wednesday, 20 December 2017 13:17:43 CET EMILIO ABRAHAM GARRIDO GARCIA wrote: > The image is a debian image, with two boot images. I can execute this: > > # virt-filesystems --long -h --all -a kvm_av_4_4_n0.qcow2 > Name Type VFS Label MBR Size Parent > /dev/sda1 filesystem ext3 BOOTMGR - 255M - > /dev/sda2 filesystem ext3 BOOT_1 - 128M - > /dev/sda3 filesystem ext3 BOOT_2 - 128M - > /dev/sda4 filesystem unknown - - 1.0K - > /dev/sda5 filesystem ext3 ROOT_1 - 2.5G - > /dev/sda6 filesystem ext3 ROOT_2 - 2.5G - > /dev/sda7 filesystem swap SWAP - 4.0G - > /dev/sda8 filesystem ext3 VAR - 80G - > /dev/sda9 filesystem ext3 CONFIG - 64M - > /dev/sda1 partition - - 83 255M /dev/sda > /dev/sda2 partition - - 83 128M /dev/sda > /dev/sda3 partition - - 83 128M /dev/sda > /dev/sda4 partition - - 0f 1.0K /dev/sda > /dev/sda5 partition - - 83 2.5G /dev/sda > /dev/sda6 partition - - 83 2.5G /dev/sda > /dev/sda7 partition - - 82 4.0G /dev/sda > /dev/sda8 partition - - 83 80G /dev/sda > /dev/sda9 partition - - 83 64M /dev/sda > /dev/sda device - - - 91G - The above does not tell me anything more than the log you already sent. What I would like to know is what is _inside_ each partition, how the various partitions related with each other (e.g. mount points/fstab), etc. -- Pino Toscano

8 years, 2 months

2
2
0 / 0

[PATCH 0/1] hivexregedit: add --max-depth option for exports

by Michael Meyer

This new option allows you to only export what you care about from a registry hive by specifying a max recursion depth. Michael Meyer (1): hivexregedit: add --max-depth option for exports perl/lib/Win/Hivex/Regedit.pm | 14 ++++++++++++-- regedit/hivexregedit | 18 +++++++++++++++++- 2 files changed, 29 insertions(+), 3 deletions(-) -- 2.14.3 (Apple Git-98)

8 years, 2 months

2
2
0 / 0

IRC question: qemu-system-arm: -machine accel=kvm:tcg: No machine specified, and there is no default

by Richard W.M. Jones

13:57 < soko> hello. i am getting an error on launch when i set-hv to an arm system. the error appears to be caused by no default machine. here is a log https://pastebin.com/CUBcnG44 13:59 < soko> the default hv works (launch, mount, etc) but fails to emulate (sh, command, etc) the binaries on the fs 14:17 < soko> if i upload qemu-arm-static and then command it works, but seems like changing the hv should work in a more clean way. any advice is appreciated! The error from the pastebin is: [00038ms] /usr/local/bin/qemu-system-arm \ -global virtio-blk-pci.scsi=off \ -enable-fips \ -nodefaults \ -display none \ -machine accel=kvm:tcg \ -m 500 \ -no-reboot \ -rtc driftfix=slew \ -global kvm-pit.lost_tick_policy=discard \ -kernel /var/tmp/.guestfs-0/appliance.d/kernel \ -initrd /var/tmp/.guestfs-0/appliance.d/initrd \ -drive file=/opt/kore_dtf/dropthefw/build_directory/5/rootfs.raw,cache=writeback,id=hd0,if=none \ -device virtio-blk-pci,drive=hd0 \ -drive file=/var/tmp/.guestfs-0/appliance.d/root,snapshot=on,id=appliance,cache=unsafe,if=none \ -device virtio-blk-pci,drive=appliance \ -device virtio-serial-pci \ -serial stdio \ -chardev socket,path=/tmp/libguestfsxlkp01/guestfsd.sock,id=channel0 \ -device virtserialport,chardev=channel0,name=org.libguestfs.channel.0 \ -append 'panic=1 console=ttyS0 udevtimeout=6000 udev.event-timeout=6000 no_timer_check lpj=8333313 acpi=off printk.time=1 cgroup_disable=memory root=/dev/vdb selinux=0 guestfs_verbose=1 TERM=xterm' qemu-system-arm: -machine accel=kvm:tcg: No machine specified, and there is no default Actually what's happening here is that soko is trying to do all of this on an x86_64 host. Unfortunately that won't work, because the appliance that is built is for x86_64 so it cannot run on top of qemu-system-arm. But also (for basic file access) it's not necessary either, just use qemu-system-x86_64. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-df lists disk usage of guests without needing to install any software inside the virtual machine. Supports Linux and Windows. http://people.redhat.com/~rjones/virt-df/

8 years, 2 months

1
0
0 / 0

Re: [Libguestfs] Compile problems

by Richard W.M. Jones

On Mon, Dec 25, 2017 at 10:47:30AM +0800, 244067545(a)qq.com wrote: > Hello! > Compile the environment information: centos7.4 libguestfs-1.36.3.tar.gz > I encountered supermin and supermin5 problems while compiling libguestfs > command: ./configure > checking for tsk/libtsk.h... yes > checking if we should build the appliance... yes > checking for supermin... /usr/bin/supermin > checking for --with-supermin-packager-config option... not set > checking for --with-supermin-extra-options option... not set > checking supermin is new enough... 4.1 > configure: error: supermin >= 5.1 must be installed, your version is too old You need to do: SUPERMIN=/usr/bin/supermin5 ./configure Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages. http://libguestfs.org

8 years, 2 months

1
0
0 / 0

Compile problems

by 244067545＠qq.com

Hello! Compile the environment information: centos7.4 libguestfs-1.36.3.tar.gz I encountered supermin and supermin5 problems while compiling libguestfs command: ./configure checking for tsk/libtsk.h... yes checking if we should build the appliance... yes checking for supermin... /usr/bin/supermin checking for --with-supermin-packager-config option... not set checking for --with-supermin-extra-options option... not set checking supermin is new enough... 4.1 configure: error: supermin >= 5.1 must be installed, your version is too old [root@zhao libguestfs-1.36.3]# yum install supermin* Loaded plugins: fastestmirror, langpacks Loading mirror speeds from cached hostfile * base: mirrors.sohu.com * epel: mirror01.idc.hinet.net * extras: mirrors.sohu.com * updates: mirrors.sohu.com Package supermin5-5.1.16-4.el7.x86_64 already installed and latest version Package supermin5-devel-5.1.16-4.el7.x86_64 already installed and latest version Package supermin-5.1.16-4.el7.x86_64 already installed and latest version Package supermin-helper-5.1.16-4.el7.x86_64 already installed and latest version Nothing to do When I use ln-s / usr / bin / supermin5 / usr / bin / supermin encounter the following problems Afer ./configure normal. make normal. make check 1 fail NTFS disk format can be modified virtual machine. I want to know how to configure ./configure to change / Supermin to supermin5 I am worried that this situation will affect the future Looking forward to your answer 244067545(a)qq.com

8 years, 2 months

1
0
0 / 0

virt-copy-in - how do I get the selinux relabeling done for the file?

by Yaniv Kaul

I'm copying a file into a VM using virt-copy-in - which is great, but the file is wrongly labeled. How can I fix that? TIA, Y.

8 years, 2 months

2
5
0 / 0

virt-customize error

by EMILIO ABRAHAM GARRIDO GARCIA

Hi, I´m need to customize a debian qcow image, but I have this error virt-customize: error: no operating systems were found in the guest image The command that I´m trying is: virt-customize -v -x -a ./kvm_av_4_4_n0.qcow2 --attach ./one_context/packages.iso -root-password password:acens --run ./ctpd/pro/scripts/one_altavault.sh --firstboot-command "dpkg-reconfigure openssh-server I attach the log. I´m wondering if is possible to specify the partition. Please, can you provide some help? BR. ________________________________ Este mensaje y sus adjuntos se dirigen exclusivamente a su destinatario, puede contener información privilegiada o confidencial y es para uso exclusivo de la persona o entidad de destino. Si no es usted. el destinatario indicado, queda notificado de que la lectura, utilización, divulgación y/o copia sin autorización puede estar prohibida en virtud de la legislación vigente. Si ha recibido este mensaje por error, le rogamos que nos lo comunique inmediatamente por esta misma vía y proceda a su destrucción. The information contained in this transmission is privileged and confidential information intended only for the use of the individual or entity named above. If the reader of this message is not the intended recipient, you are hereby notified that any dissemination, distribution or copying of this communication is strictly prohibited. If you have received this transmission in error, do not read it. Please immediately reply to the sender that you have received this communication in error and then delete it. Esta mensagem e seus anexos se dirigem exclusivamente ao seu destinatário, pode conter informação privilegiada ou confidencial e é para uso exclusivo da pessoa ou entidade de destino. Se não é vossa senhoria o destinatário indicado, fica notificado de que a leitura, utilização, divulgação e/ou cópia sem autorização pode estar proibida em virtude da legislação vigente. Se recebeu esta mensagem por erro, rogamos-lhe que nos o comunique imediatamente por esta mesma via e proceda a sua destruição

8 years, 2 months

3
2
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

Libguestfs December 2017