August 2021 - Libguestfs - libguestfs List Archives

[PATCH] spec: Relax NBD_OPT_LIST_META_CONTEXTS
by Eric Blake 06 Sep '21

06 Sep '21

Using OPT_SET_META_CONTEXTS is stateful (it is documented to wipe out any previously-requested contexts, and we just tightened the spec to clarify that starting TLS also wipes it out). But OPT_LIST_META_CONTEXTS is not stateful; and in fact, with a SELECTIVETLS server, it can be handy to list the meta contexts available on an unencrypted export, then enable encryption, and then further list what contexts are available on encrypted exports (as the server is permitted to let them differ). Thus, while a wise client will renegotiate structured replies after the starttls, there's no reason to forbid a server from answering a client that uses list_meta_contexts prior to encryption without also requesting structured replies. --- doc/proto.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/proto.md b/doc/proto.md index 9dd59da..1586d7d 100644 --- a/doc/proto.md +++ b/doc/proto.md @@ -1325,9 +1325,9 @@ of the newstyle negotiation. Return a list of `NBD_REP_META_CONTEXT` replies, one per context, followed by an `NBD_REP_ACK` or an error. - This option MUST NOT be requested unless structured replies have + This option SHOULD NOT be requested unless structured replies have been negotiated first. If a client attempts to do so, a server - SHOULD send `NBD_REP_ERR_INVALID`. + MAY send `NBD_REP_ERR_INVALID`. Data: - 32 bits, length of export name. -- 2.31.1

2 2

[PATCH] appliance: Fix searching for shared libraries on usr-merged Debian systems
by Hilko Bengen 31 Aug '21

31 Aug '21

If /lib is a symlink to usr/lib, paths to shared libraries as determined by ld.so may differ from dpkg's file lists. We turn the filename search pattern into a glob expression by prefixing it with a '*', so the required packages are found again: $ dpkg -S /lib/x86_64-linux-gnu/libpcre2-8.so.0 dpkg-query: no path found matching pattern /lib/x86_64-linux-gnu/libpcre2-8.so.0 $ dpkg -S */lib/x86_64-linux-gnu/libpcre2-8.so.0 libpcre2-8-0:amd64: /usr/lib/x86_64-linux-gnu/libpcre2-8.so.0 --- appliance/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/appliance/Makefile.am b/appliance/Makefile.am index a213e12be4..6dd1df75a6 100644 --- a/appliance/Makefile.am +++ b/appliance/Makefile.am @@ -84,7 +84,7 @@ if HAVE_RPM QUERY_FILES_CMD := xargs rpm -qf --qf '%{name}\n' endif if HAVE_DPKG -QUERY_FILES_CMD := xargs dpkg -S | cut -d: -f1 +QUERY_FILES_CMD := sed -e 's,^/,\*/,' | xargs dpkg -S | cut -d: -f1 endif if HAVE_PACMAN QUERY_FILES_CMD := xargs pacman -Qo | sed -r 's/.* is owned by ([^ ]+) .*/\1/' -- 2.32.0.rc0

2 1

Fwd: libnbd | Failed pipeline for master | 2e381ac2
by Richard W.M. Jones 31 Aug '21

31 Aug '21

>From the log: https://gitlab.com/nbdkit/libnbd/-/jobs/1540375264 opensuse zypper seems to be failing with a recoverable error: Resolving package dependencies... Problem: the to be installed glib2-devel-2.68.3-4.1.x86_64 requires 'libglib-2_0-0 = 2.68.3', but this requirement cannot be provided not installable providers: libglib-2_0-0-2.68.3-4.1.i586[repo-oss] libglib-2_0-0-2.68.3-4.1.x86_64[repo-oss] Solution 1: downgrade of libglib-2_0-0-2.68.4-1.1.x86_64 to libglib-2_0-0-2.68.3-4.1.x86_64 Solution 2: do not install glib2-devel-2.68.3-4.1.x86_64 Solution 3: break glib2-devel-2.68.3-4.1.x86_64 by ignoring some of its dependencies Choose from above solutions by number or cancel [1/2/3/c/d/?] (c): c I wonder if this is something that libvirt-ci should handle better? I found this thread which seems to indicate there's no way to force zypper to pick an option: https://www.linuxquestions.org/questions/suse-opensuse-60/how-to-pre-select… which is kind of annoying. But maybe --force-resolution is worth a try? Rich. ----- Forwarded message from GitLab <gitlab(a)mg.gitlab.com> ----- Date: Fri, 27 Aug 2021 09:52:55 +0000 From: GitLab <gitlab(a)mg.gitlab.com> Subject: libnbd | Failed pipeline for master | 2e381ac2 GitLab ✖ Pipeline #360603274 has failed! Project nbdkit / libnbd Branch ● master Commit ● 2e381ac2 interop: Prerequisite qemu-nbd supports TLS Fe... Commit Author ● Richard W.M. Jones Pipeline #360603274 triggered by ● Richard W.M. Jones had 1 failed job. Failed jobs ✖ containers x64-opensuse-tumbleweed-container ----- End forwarded message ----- -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 100 libraries supported. http://fedoraproject.org/wiki/MinGW

3 4

About submitting patches for the website
by Alexandre IOOSS 28 Aug '21

28 Aug '21

Hello, Is there somewhere where I could find the source code of https://libguestfs.org/ website? I could propose some patches to update the website. Thanks, -- Alexandre

2 1

[PATCH] build: Define HAVE_RPM, HAVE_DPKG and HAVE_PACMAN
by Alexandre Iooss 27 Aug '21

27 Aug '21

When using option `--with-distro`, `HAVE_RPM`, `HAVE_DPKG` and `HAVE_PACMAN` are not defined and make the configure phase fail. This makes sure that these conditionals are always defined. --- m4/guestfs-appliance.m4 | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/m4/guestfs-appliance.m4 b/m4/guestfs-appliance.m4 index 8b9ddcb..66aea5f 100644 --- a/m4/guestfs-appliance.m4 +++ b/m4/guestfs-appliance.m4 @@ -114,16 +114,16 @@ AC_ARG_WITH([distro], AC_MSG_ERROR([/etc/os-release not available, please specify the distro using --with-distro=DISTRO]) fi ] - AM_CONDITIONAL([HAVE_RPM], - [AS_CASE([$DISTRO], [REDHAT | SUSE | OPENMANDRIVA | MAGEIA ], [true], - [*], [false])]) - AM_CONDITIONAL([HAVE_DPKG], - [AS_CASE([$DISTRO], [DEBIAN | UBUNTU ], [true], - [*], [false])]) - AM_CONDITIONAL([HAVE_PACMAN], - [AS_CASE([$DISTRO], [ARCHLINUX | FRUGALWARE ], [true], - [*], [false])]) ) +AM_CONDITIONAL([HAVE_RPM], + [AS_CASE([$DISTRO], [REDHAT | SUSE | OPENMANDRIVA | MAGEIA ], [true], + [*], [false])]) +AM_CONDITIONAL([HAVE_DPKG], + [AS_CASE([$DISTRO], [DEBIAN | UBUNTU ], [true], + [*], [false])]) +AM_CONDITIONAL([HAVE_PACMAN], + [AS_CASE([$DISTRO], [ARCHLINUX | FRUGALWARE ], [true], + [*], [false])]) AC_SUBST([DISTRO]) dnl Add extra packages to the appliance. -- 2.31.1

2 1

[libguestfs] Problem building appliance/guestfsd.deps on debian
by Richard W.M. Jones 27 Aug '21

27 Aug '21

Hi hillu, We have a report of a problem with building appliance/guestfsd.deps on Debian 10. This code which you contributed: https://github.com/libguestfs/libguestfs/commit/133a49167778195f0cf043a1d38… seems to cause problems with certain libraries which are symlinks. In particular: dpkg-query: no path found matching pattern /lib/x86_64-linux-gnu/libacl.so.1 (and for some other libraries) which causes the final guestfsd.deps to be incomplete. Note /lib/x86_64-linux-gnu/libacl.so.1 exists but is a symlink. When the reporter tries to boot the appliance, guestfsd cannot be loaded because: guestfsd: error while loading shared libraries: libjansson.so.4: cannot open shared object file: No such file or directory Any ideas what's going on here? Thanks, Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-builder quickly builds VMs from scratch http://libguestfs.org/virt-builder.1.html

2 1

Re: [Libguestfs] [libguestfs/libguestfs] Is it possible to mount the entire disk raw? (#72)
by Richard W.M. Jones 27 Aug '21

27 Aug '21

On Fri, Aug 27, 2021 at 02:40:30AM -0700, Joseph Lee wrote: > There is qcowmount as a similar project, but it has the disadvantage of not > being able to write. > Is it possible to mount the whole disk to the host like this? nbdfuse, part of the libnbd project, can do this (with writes). In fact there is an example of doing exactly this in the manual: https://libguestfs.org/nbdfuse.1.html#Use-qemu-nbd-to-read-and-modify-a-qco… https://gitlab.com/nbdkit/libnbd By the way I would be extremely wary of any tool which claims to process qcow2 files but is not using qemu code to do it. nbdfuse uses qemu-nbd (ie qemu code). Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://people.redhat.com/~rjones/virt-top

1 0

online-p2v
by yugang＠bjtengling.com 27 Aug '21

27 Aug '21

Hi there, Is there possiable that virt-p2v can convert Physical computer online? Which means do not reboot or start it through U disk. Do we have plan on this, is there any other tool can do this? Thanks Ewan yugang(a)bjtengling.com

2 5

[PATCH libnbd] tests: Use libc_malloc_debug.so.0 instead of MALLOC_CHECK_ for glibc 2.34
by Richard W.M. Jones 26 Aug '21

26 Aug '21

This is the nbdkit change transplanted to libnbd. Because there are several subdirectory Makefiles which define the MALLOC_CHECK_ environment variables, I turned it into a macro which is placed in the top level subdir-rules.mk. Note this currently breaks valgrinding because of: https://sourceware.org/bugzilla/show_bug.cgi?id=28256 and because there's not a good place to unset GLIBC_TUNABLES in libnbd. Rich.

2 5

nbdcpy: from scratch nbdcopy using io_uring
by Abhay Raj Singh 25 Aug '21

25 Aug '21

In a previous email, Mr. Jones suggested, writing a test implementation of nbdcopy from scratch. First of all, thank you, Mr. Jones, as I got a better perspective of the problem and the solution. I have almost written the bare-bones implementation for handling NBD-related stuff on which I will base the io_uring core piece by piece. It is written in C++, as I am more comfortable with it. But, made it easily translatable to C. I have been working on a solution and have documented the current approach, it would be great if you have a look at it and let me know what you think. Approach document: https://gitlab.com/rathod-sahaab/nbdcpy/-/blob/dev/docs/SOLUTION.md Thanks and regards, Abhay

3 16