[PATCH v5 00/10] Introducing virt-builder-repository
by Cédric Bosdonnat
Hi all,
Here is the v5 of my patches series applying the latest comments
from Pino.
Cédric Bosdonnat (10):
lib/osinfo.c: Extract xml processing into a callback
lib: extract osinfo DB traversing API
mllib: ocaml wrapper for lib/osinfo
builder: rename docs test script
builder: add a template parameter to get_index
builder: add Index.write_entry function
dib: move do_cp to mllib.Commun_utils
mllib: add do_mv helper function to Common_utils
mllib: add XPath helper xpath_get_nodes()
Add a virt-builder-repository tool
.gitignore | 4 +
builder/Makefile.am | 121 ++++-
builder/builder.ml | 2 +-
builder/index.mli | 3 +
builder/index_parser.ml | 74 +++-
builder/index_parser.mli | 8 +-
builder/index_parser_tests.ml | 129 ++++++
builder/repository_main.ml | 488 +++++++++++++++++++++
.../{test-virt-builder-docs.sh => test-docs.sh} | 2 +
builder/virt-builder-repository.pod | 183 ++++++++
dib/utils.ml | 4 -
lib/Makefile.am | 2 +
lib/osinfo-iso.c | 462 +++++++++++++++++++
lib/osinfo.c | 477 ++------------------
lib/osinfo.h | 27 ++
mllib/Makefile.am | 11 +-
mllib/common_utils.ml | 11 +
mllib/common_utils.mli | 6 +
mllib/osinfo-c.c | 102 +++++
mllib/osinfo.ml | 26 ++
mllib/osinfo.mli | 31 ++
mllib/xpath_helpers.ml | 9 +
mllib/xpath_helpers.mli | 4 +
23 files changed, 1727 insertions(+), 459 deletions(-)
create mode 100644 builder/index_parser_tests.ml
create mode 100644 builder/repository_main.ml
rename builder/{test-virt-builder-docs.sh => test-docs.sh} (93%)
create mode 100644 builder/virt-builder-repository.pod
create mode 100644 lib/osinfo-iso.c
create mode 100644 lib/osinfo.h
create mode 100644 mllib/osinfo-c.c
create mode 100644 mllib/osinfo.ml
create mode 100644 mllib/osinfo.mli
--
2.12.0
7 years, 7 months
[PATCH v4 0/7] Feature: Yara file scanning
by Matteo Cafasso
Rebase patches on top of 1.37.1.
No changes since last series.
Matteo Cafasso (7):
daemon: expose file upload logic
appliance: add yara dependency
New API: yara_load
New API: yara_destroy
New API: internal_yara_scan
New API: yara_scan
yara_scan: added API tests
appliance/packagelist.in | 4 +
configure.ac | 1 +
daemon/Makefile.am | 4 +-
daemon/cleanups.c | 9 +
daemon/cleanups.h | 2 +
daemon/daemon.h | 3 +
daemon/upload.c | 70 +++----
daemon/yara.c | 301 +++++++++++++++++++++++++++++++
generator/Makefile.am | 3 +
generator/actions.ml | 6 +-
generator/proc_nr.ml | 3 +
generator/structs.ml | 9 +
gobject/Makefile.inc | 8 +-
java/Makefile.inc | 1 +
java/com/redhat/et/libguestfs/.gitignore | 1 +
lib/MAX_PROC_NR | 2 +-
lib/Makefile.am | 1 +
lib/yara.c | 127 +++++++++++++
m4/guestfs_daemon.m4 | 14 ++
tests/yara/Makefile.am | 26 +++
tests/yara/test-yara-scan.sh | 72 ++++++++
21 files changed, 630 insertions(+), 37 deletions(-)
create mode 100644 daemon/yara.c
create mode 100644 lib/yara.c
create mode 100644 tests/yara/Makefile.am
create mode 100755 tests/yara/test-yara-scan.sh
--
2.11.0
7 years, 7 months
[PATCH 0/3] Fix some quoting issues.
by Richard W.M. Jones
Fix some quoting issues by introducing Unicode quotes.
Note this intentionally only affects end-user messages and documentation.
Rich.
7 years, 7 months
[PATCH 0/3] p2v, v2v: Ensure the full version is always available in several places.
by Richard W.M. Jones
After debugging a virt-p2v issue with a customer in the middle of the
night on Tuesday, I felt it would have been helpful to know exactly
which version(s) of virt-p2v and virt-v2v they were using. That
wasn't very clear from the log file I was provided with, so this
change makes sure the information is included every time.
Rich.
7 years, 7 months
[PATCH 1/2] p2v: move the license text to gui.c
by Pino Toscano
It is used only for the about dialog, and this way it will be easier
to disable.
---
p2v/Makefile.am | 1 -
p2v/about-license.c | 38 --------------------------------------
p2v/gui.c | 16 ++++++++++++++++
p2v/p2v.h | 3 ---
4 files changed, 16 insertions(+), 42 deletions(-)
delete mode 100644 p2v/about-license.c
diff --git a/p2v/Makefile.am b/p2v/Makefile.am
index 3526d7a..c78f4ab 100644
--- a/p2v/Makefile.am
+++ b/p2v/Makefile.am
@@ -78,7 +78,6 @@ noinst_PROGRAMS = virt-p2v
virt_p2v_SOURCES = \
about-authors.c \
- about-license.c \
config.c \
conversion.c \
cpuid.c \
diff --git a/p2v/about-license.c b/p2v/about-license.c
deleted file mode 100644
index 70d7b77..0000000
--- a/p2v/about-license.c
+++ /dev/null
@@ -1,38 +0,0 @@
-/* virt-p2v
- * Copyright (C) 2009-2017 Red Hat Inc.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
- */
-
-#include <config.h>
-
-#include "p2v.h"
-
-/* The license of virt-p2v, for the About dialog. */
-
-const char *gplv2plus =
- "This program is free software; you can redistribute it and/or modify\n"
- "it under the terms of the GNU General Public License as published by\n"
- "the Free Software Foundation; either version 2 of the License, or\n"
- "(at your option) any later version.\n"
- "\n"
- "This program is distributed in the hope that it will be useful,\n"
- "but WITHOUT ANY WARRANTY; without even the implied warranty of\n"
- "MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the\n"
- "GNU General Public License for more details.\n"
- "\n"
- "You should have received a copy of the GNU General Public License\n"
- "along with this program; if not, write to the Free Software\n"
- "Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.\n";
diff --git a/p2v/gui.c b/p2v/gui.c
index 82c2402..563e1a7 100644
--- a/p2v/gui.c
+++ b/p2v/gui.c
@@ -134,6 +134,22 @@ static GtkWidget *run_dlg,
/* Colour tags used in the v2v_output GtkTextBuffer. */
static GtkTextTag *v2v_output_tags[16];
+/* The license of virt-p2v, for the About dialog. */
+static const char gplv2plus[] =
+ "This program is free software; you can redistribute it and/or modify\n"
+ "it under the terms of the GNU General Public License as published by\n"
+ "the Free Software Foundation; either version 2 of the License, or\n"
+ "(at your option) any later version.\n"
+ "\n"
+ "This program is distributed in the hope that it will be useful,\n"
+ "but WITHOUT ANY WARRANTY; without even the implied warranty of\n"
+ "MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the\n"
+ "GNU General Public License for more details.\n"
+ "\n"
+ "You should have received a copy of the GNU General Public License\n"
+ "along with this program; if not, write to the Free Software\n"
+ "Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.\n";
+
/**
* The entry point from the main program.
*
diff --git a/p2v/p2v.h b/p2v/p2v.h
index bd4b484..4a47e9f 100644
--- a/p2v/p2v.h
+++ b/p2v/p2v.h
@@ -194,7 +194,4 @@ extern const char *qa[];
extern const char *documenters[];
extern const char *others[];
-/* about-license.c */
-extern const char *gplv2plus;
-
#endif /* P2V_H */
--
2.9.3
7 years, 7 months
[PATCH] mllib: cast integer pointers to intptr_t as intermediate step
by Pino Toscano
This make sure there is no mismatch between the size of the integer
value that Int64_val returns, and the size of the guestfs_h pointer.
This should fix the warning on 32bit environments (and thus build, when
--enable-werror is enabled).
---
mllib/visit-c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mllib/visit-c.c b/mllib/visit-c.c
index b46dd33..b1c1216 100644
--- a/mllib/visit-c.c
+++ b/mllib/visit-c.c
@@ -54,7 +54,7 @@ value
guestfs_int_mllib_visit (value gv, value dirv, value fv)
{
CAMLparam3 (gv, dirv, fv);
- guestfs_h *g = (guestfs_h *) Int64_val (gv);
+ guestfs_h *g = (guestfs_h *) (intptr_t) Int64_val (gv);
struct visitor_function_wrapper_args args;
/* The dir string could move around when we call the
* visitor_function, so we have to take a full copy of it.
--
2.9.3
7 years, 7 months
Virt-win-reg does not exist
by Keresztes Péter-Zoltán
Hello,
I have compiled the latest version of libguestfs on Debian jessie with no flags specified and virt-win-reg does not exist as a tool. Do I need to specify any flag to have that available?
Regards,
Peter
7 years, 7 months
libguestfs preview for RHEL 7.4
by Richard W.M. Jones
With the release of RHEL 7.3 happening today, fixing 88 reported bugs
in libguestfs and virt-v2v, and countless other ones, it's time to
look ahead to RHEL 7.4.
Again we intend to rebase libguestfs, virt-v2v and virt-p2v:
https://bugzilla.redhat.com/show_bug.cgi?id=1359086
1359086 NEW Rebase libguestfs in RHEL 7.4
To help with testing I have set up a preview repository here:
http://people.redhat.com/~rjones/libguestfs-RHEL-7.4-preview/
As always:
(1) THE PACKAGES ARE NOT SUPPORTED! Do not contact Red Hat Support
about these packages. However you are welcome to file bugs or send
comments to <libguestfs(a)redhat.com>. The link for filing bugs is:
https://bugzilla.redhat.com/enter_bug.cgi?product=Red%20Hat%20Enterprise%...
(2) These packages should work on top of RHEL 7.3 or CentOS 7.3.
(3) To install the packages you should create a yum repo file like the
one below, and then use yum commands as normal:
$ cat /etc/yum.repos.d/libguestfs-RHEL-7.4-preview.repo
[libguestfs-RHEL-7.4-preview]
name=libguestfs RHEL 7.4 preview
baseurl=http://people.redhat.com/~rjones/libguestfs-RHEL-7.4-preview/
enabled=1
gpgcheck=0
Notable changes in packaging:
- The 'virt-v2v' package now only includes virt-v2v, not virt-p2v.
- To build your own virt-p2v bootable USB key, install 'virt-p2v-maker'.
- virt-v2v installs Windows virtio drivers using a new technique
which tries to make the minimal possible changes to the Windows
registry. This may create exciting new bugs, so I'm particularly
interested in further testing in this area.
- There is currently a bogus dependency on 'kernel-rt' which
shouldn't be there ... under investigation.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-builder quickly builds VMs from scratch
http://libguestfs.org/virt-builder.1.html
7 years, 7 months
