Re: [Libguestfs] [libnbd PATCH v4 3/5] remove semicolon after DEFINE_VECTOR_TYPE() macro invocations
On Fri, Feb 24, 2023 at 09:04:29AM -0600, Eric Blake wrote:
On Fri, Feb 24, 2023 at 05:39:35AM +0100, Laszlo Ersek wrote:
> A semicolon after a DEFINE_VECTOR_TYPE(...) macro invocation is not
> needed, nor does our documentation in "common/utils/vector.h" prescribe
> one.
...
I agree that our code base is inconsistent on whether we supply or
omit a trailing semicolon, but I would also like to appease the editor
syntax engine. What if we instead go for a consistent style in the
opposite direction? My counter-proposal: hack the definition of the
macro to REQUIRE that callers include a trailing semicolon. Here's
the easiest way I could think of:
Oh, plus I'd also need to document the usage comment in vector.h to
document this style, if we want to go with this approach.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org