Re: [Libguestfs] [PATCH libnbd v2 3/4] generator: Add APIs to get/set the socket activation socket name

> > + /* Check the proposed name is short and alphanumeric. */ > > + if (len > 32) { > > + set_error (ENAMETOOLONG, "socket activation name should be " > > + "<= 32 characters"); > > I don't mind keeping us strict to start with and loosening it later if > someone demonstrates why it is needed. But systemd documents a larger > set of possible names: > > https://www.freedesktop.org/software/systemd/man/sd_pid_notify_with_fds.html > > FDNAME=… > > When used in combination with FDSTORE=1, specifies a name for the > submitted file descriptors. When used with FDSTOREREMOVE=1, > specifies the name for the file descriptors to remove. This name > is passed to the service during activation, and may be queried > using sd_listen_fds_with_names(3). File descriptors submitted > without this field set, will implicitly get the name "stored" > assigned. Note that, if multiple file descriptors are submitted at > once, the specified name will be assigned to all of them. In order > to assign different names to submitted file descriptors, submit > them in separate invocations of sd_pid_notify_with_fds(). The name > may consist of arbitrary ASCII characters except control > characters or ":". It may not be longer than 255 characters. If a > submitted name does not follow these restrictions, it is ignored. I didn't know about this documentation before.

Arbitrary ASCII characters doesn't sound that great though. I'm sure that q-s-d will want its own much more strict limitations, eg. I assume you can't possibly support any characters which are meaningful to JSON / QMP. Any thoughts on that?