Re: [Libguestfs] [PATCH v2] fish: show synopsis if command syntax is wrong
On Tue, Dec 02, 2014 at 09:21:24AM +0800, Hu Tao wrote:
On Mon, Dec 01, 2014 at 06:01:25PM +0000, Richard W.M. Jones wrote:
>
> How about the following? I've made it use a named value
> (RUN_WRONG_ARGS == -2) instead of just the magic number.
Yes, it looks better!
>
> Also I removed an incorrect hunk from the original patch (space before
> synopsis string is required).
The space before synopsis makes the text of synopsis misaligned. I don't
know why it's required, but if it does, the patch looks good to me.
Space before a line in POD means the line is verbatim formatted.
Thanks - I have pushed the patch.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines. Supports shell scripting,
bindings from many languages. http://libguestfs.org