Re: [Libguestfs] [libnbd PATCH v2 3/3] nbdsh: Improve --help and initial banner contents.
On Sat, Nov 05, 2022 at 03:39:26AM +0200, Nir Soffer wrote:
On Fri, Nov 4, 2022 at 11:18 PM Eric Blake <eblake(a)redhat.com>
wrote:
[...]
> @@ -127,7 +129,10 @@ def __call__(self, parser, namespace, values,
> option_string=None):
> os.environ["LIBNBD_DEBUG"] = "1"
>
> # Create the handle.
> - if not args.n:
> + if args.n:
> + pass
> + else:
>
Why add useless branch?
At one point in the evolution of my patch, I tried setting 'h = None'
in the args.n branch, but that broke sh/test-implicit-handle.sh. The
fact that I dropped it back to pass instead of deleting the dead
branch was a poor rebase act on my part; I'll clean it back up to the
original if not args.n branching.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org