Re: [Libguestfs] [PATCH v3 2/3] v2v: OVF: write ovirt:id attribute for the OS in OVirt flavour

On Thu, 5 Apr 2018 14:53:51 +0200 Pino Toscano <ptoscano(a)redhat.com&gt; wrote: > @@ -383,8 +581,9 @@ let rec create_ovf source targets guestcaps inspect > ] in > (match ovf_flavour with > | OVirt -> > - e "OperatingSystemSection" ["ovf:id", vm_uuid; > - "ovf:required", "false"] > + let ovirt_osid = get_ovirt_osid inspect in > + e "OperatingSystemSection" ["ovf:required", "false"; > + "ovirt:id", string_of_int ovirt_osid] Sadly, OVF schema says ovf:id is reqiured. But since the generated OVF is not used by anything besides oVirt I think we can live without it.