Re: [Libguestfs] [nbdkit PATCH] log: Implement .block_size callback
On Mon, Feb 21, 2022 at 07:32:41PM +0000, Richard W.M. Jones wrote:
On Mon, Feb 21, 2022 at 10:59:39AM -0600, Eric Blake wrote:
> Enhance the amount of information logged during connection.
> ---
> filters/log/nbdkit-log-filter.pod | 2 +-
> filters/log/log.c | 12 ++++++++----
> 2 files changed, 9 insertions(+), 5 deletions(-)
>
ACK
Rich.
Now in as 842bf64122
The swab filter should probably also consider a .block_size; there, we
can still support unaligned reads, but due to the overhead of byte
swapping, we want to ensure preferred size is at least our swap
alignment (but then again, the NBD spec says a preferred size has to
be at least 512, which is larger than our swap alignment.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org