Re: [Libguestfs] [libnbd PATCH v3 01/10] rust: create basic Rust bindings
On 7/27/2023 9:43 AM, Richard W.M. Jones wrote:
On Wed, Jul 26, 2023 at 09:58:03AM +0000, Tage Johansson wrote:
> I have never used rpm, but if you are using Fedora, the following command
> should be enough:
>
> dnf install clang-devel
We need to work with whatever environment we find ourselves in. We
can't just fail because of a missing dependency, but instead should
disable the rust bindings (we can however fail at ./configure time if
--enable-rust was given explicitly but is not possible).
This is the reason for having ./configure at all.
> According to this link.
>
>
> I seem to remember in some project we had a configure-time test to
> check if rust/cargo was working, compiling a simple test program, but
> I can't find that right now.
>
> Rich.
>
>
> That was actually this project. I removed it because we both thought it was
> unnecessary. And I actually think it wouldn't catch this problem anyway because
> this is directly related to rust-bindgen.
Since this seems to be caused by rust-bindgen, which we don't need,
can we get rid of bindgen now?
I'll work on it this week. I found a bug in the asynchronous API which
took most of my time previous week. Think I have solved it now, but the
implementation is slightly changed.
Best regards,
Tage
Rich.