Re: [Libguestfs] [PATCH libguestfs] build: daemon/do_debug: parameters aren't always unused
Daniel P. Berrange wrote:
On Mon, Aug 10, 2009 at 11:59:21AM +0100, Richard W.M. Jones wrote:
> On Mon, Aug 10, 2009 at 12:47:20PM +0200, Jim Meyering wrote:
> > Thanks to the reminder from Dan Berrange,
> > here's a patch to make build output less verbose, by default.
> > E.g., instead of the redundant multi-line compilation/linking commands,
> > you'll see something like this by default:
> > +AM_SILENT_RULES([yes]) # make --enable-silent-rules the default.
>
> I tried this one before but it doesn't work on RHEL 5.3:
>
> aclocal:configure.ac:27: warning: macro `AM_SILENT_RULES' not found in library
> libtoolize: `config.guess' exists: use `--force' to overwrite
> libtoolize: `config.sub' exists: use `--force' to overwrite
> libtoolize: `ltmain.sh' exists: use `--force' to overwrite
> aclocal:configure.ac:27: warning: macro `AM_SILENT_RULES' not found in library
> configure.ac:27: error: possibly undefined macro: AM_SILENT_RULES
> If this token and others are legitimate, please use m4_pattern_allow.
> See the Autoconf documentation.
> autoreconf: /usr/bin/autoconf failed with exit status: 1
There's an easy hack to fix that. Just add this to the top of configure.ac
m4_ifndef([AM_SILENT_RULES], [m4_define([AM_SILENT_RULES],[])])
that just turns AM_SILENT_RULES into a no-op for places where its not
available.
Thanks for the reminder, Dan.
Here's an updated patch:
From 0ef1036b57190610577e21a90667c6368e593827 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering(a)redhat.com>
Date: Mon, 10 Aug 2009 12:44:09 +0200
Subject: [PATCH libguestfs] build: enable automake's silent rules option
* configure.ac: Use AM_SILENT_RULES([yes]).
Those who want verbose build output may configure with
--disable-silent-rules or use "make V=1".
* daemon/configure.ac: Likewise.
---
configure.ac | 3 +++
daemon/configure.ac | 3 +++
2 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/configure.ac b/configure.ac
index cf0591d..a78ca51 100644
--- a/configure.ac
+++ b/configure.ac
@@ -26,6 +26,9 @@
AC_INIT([libguestfs],libguestfs_major.libguestfs_minor.libguestfs_release[]libgu
AC_CONFIG_AUX_DIR([build-aux])
AM_INIT_AUTOMAKE([foreign])
+m4_ifndef([AM_SILENT_RULES], [m4_define([AM_SILENT_RULES],[])])
+AM_SILENT_RULES([yes]) # make --enable-silent-rules the default.
+
AC_CONFIG_MACRO_DIR([m4])
AC_PROG_LIBTOOL
diff --git a/daemon/configure.ac b/daemon/configure.ac
index b038d17..43e331b 100644
--- a/daemon/configure.ac
+++ b/daemon/configure.ac
@@ -19,6 +19,9 @@ AC_INIT([libguestfs-daemon],[1.0.0])
AC_CONFIG_AUX_DIR([build-aux])
AM_INIT_AUTOMAKE([foreign])
+m4_ifndef([AM_SILENT_RULES], [m4_define([AM_SILENT_RULES],[])])
+AM_SILENT_RULES([yes]) # make --enable-silent-rules the default.
+
AC_CONFIG_MACRO_DIR([m4])
dnl If the user specified --enable-32bit, then force the C compiler
--
1.6.4.300.gc9df