[PATCH libguestfs] build: daemon/do_debug: parameters aren't always unused
Thanks to the reminder from Dan Berrange, here's a patch to make build output less verbose, by default. E.g., instead of the redundant multi-line compilation/linking commands, you'll see something like this by default: CC guestfsd-fsck.o CC guestfsd-grep.o CC guestfsd-grub.o CC guestfsd-glob.o CC guestfsd-guestfsd.o CC guestfsd-headtail.o CC guestfsd-hexdump.o CC guestfsd-initrd.o CC guestfsd-inotify.o ... CC guestfsd-zero.o CC guestfsd-zerofree.o CCLD guestfsd If you want to diagnose a problem, or just prefer to see full commands, build with "make V=1".
From 4a2e4d21c49ed47dea15a2ccf3cb06e210626742 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering@redhat.com> Date: Mon, 10 Aug 2009 12:44:09 +0200 Subject: [PATCH libguestfs] build: enable automake's silent rules option
* configure.ac: Use AM_SILENT_RULES([yes]). Those who want verbose build output may configure with --disable-silent-rules or use "make V=1". * daemon/configure.ac: Likewise. --- configure.ac | 1 + daemon/configure.ac | 1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/configure.ac b/configure.ac index cf0591d..f2d05dd 100644 --- a/configure.ac +++ b/configure.ac @@ -25,6 +25,7 @@ m4_define([libguestfs_extra], []) AC_INIT([libguestfs],libguestfs_major.libguestfs_minor.libguestfs_release[]libguestfs_extra) AC_CONFIG_AUX_DIR([build-aux]) AM_INIT_AUTOMAKE([foreign]) +AM_SILENT_RULES([yes]) # make --enable-silent-rules the default. AC_CONFIG_MACRO_DIR([m4]) diff --git a/daemon/configure.ac b/daemon/configure.ac index b038d17..3abc306 100644 --- a/daemon/configure.ac +++ b/daemon/configure.ac @@ -18,6 +18,7 @@ AC_INIT([libguestfs-daemon],[1.0.0]) AC_CONFIG_AUX_DIR([build-aux]) AM_INIT_AUTOMAKE([foreign]) +AM_SILENT_RULES([yes]) # make --enable-silent-rules the default. AC_CONFIG_MACRO_DIR([m4]) -- 1.6.4.300.gc9df
On Mon, Aug 10, 2009 at 12:47:20PM +0200, Jim Meyering wrote:
Thanks to the reminder from Dan Berrange, here's a patch to make build output less verbose, by default. E.g., instead of the redundant multi-line compilation/linking commands, you'll see something like this by default: +AM_SILENT_RULES([yes]) # make --enable-silent-rules the default.
I tried this one before but it doesn't work on RHEL 5.3: aclocal:configure.ac:27: warning: macro `AM_SILENT_RULES' not found in library libtoolize: `config.guess' exists: use `--force' to overwrite libtoolize: `config.sub' exists: use `--force' to overwrite libtoolize: `ltmain.sh' exists: use `--force' to overwrite aclocal:configure.ac:27: warning: macro `AM_SILENT_RULES' not found in library configure.ac:27: error: possibly undefined macro: AM_SILENT_RULES If this token and others are legitimate, please use m4_pattern_allow. See the Autoconf documentation. autoreconf: /usr/bin/autoconf failed with exit status: 1 (There was another one I wanted to add to do with colouring error messages, that also doesn't work on RHEL 5). Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into Xen guests. http://et.redhat.com/~rjones/virt-p2v
On Mon, Aug 10, 2009 at 11:59:21AM +0100, Richard W.M. Jones wrote:
On Mon, Aug 10, 2009 at 12:47:20PM +0200, Jim Meyering wrote:
Thanks to the reminder from Dan Berrange, here's a patch to make build output less verbose, by default. E.g., instead of the redundant multi-line compilation/linking commands, you'll see something like this by default: +AM_SILENT_RULES([yes]) # make --enable-silent-rules the default.
I tried this one before but it doesn't work on RHEL 5.3:
aclocal:configure.ac:27: warning: macro `AM_SILENT_RULES' not found in library libtoolize: `config.guess' exists: use `--force' to overwrite libtoolize: `config.sub' exists: use `--force' to overwrite libtoolize: `ltmain.sh' exists: use `--force' to overwrite aclocal:configure.ac:27: warning: macro `AM_SILENT_RULES' not found in library configure.ac:27: error: possibly undefined macro: AM_SILENT_RULES If this token and others are legitimate, please use m4_pattern_allow. See the Autoconf documentation. autoreconf: /usr/bin/autoconf failed with exit status: 1
There's an easy hack to fix that. Just add this to the top of configure.ac m4_ifndef([AM_SILENT_RULES], [m4_define([AM_SILENT_RULES],[])]) that just turns AM_SILENT_RULES into a no-op for places where its not available. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
Daniel P. Berrange wrote:
On Mon, Aug 10, 2009 at 11:59:21AM +0100, Richard W.M. Jones wrote:
On Mon, Aug 10, 2009 at 12:47:20PM +0200, Jim Meyering wrote:
Thanks to the reminder from Dan Berrange, here's a patch to make build output less verbose, by default. E.g., instead of the redundant multi-line compilation/linking commands, you'll see something like this by default: +AM_SILENT_RULES([yes]) # make --enable-silent-rules the default.
I tried this one before but it doesn't work on RHEL 5.3:
aclocal:configure.ac:27: warning: macro `AM_SILENT_RULES' not found in library libtoolize: `config.guess' exists: use `--force' to overwrite libtoolize: `config.sub' exists: use `--force' to overwrite libtoolize: `ltmain.sh' exists: use `--force' to overwrite aclocal:configure.ac:27: warning: macro `AM_SILENT_RULES' not found in library configure.ac:27: error: possibly undefined macro: AM_SILENT_RULES If this token and others are legitimate, please use m4_pattern_allow. See the Autoconf documentation. autoreconf: /usr/bin/autoconf failed with exit status: 1
There's an easy hack to fix that. Just add this to the top of configure.ac
m4_ifndef([AM_SILENT_RULES], [m4_define([AM_SILENT_RULES],[])])
that just turns AM_SILENT_RULES into a no-op for places where its not available.
Thanks for the reminder, Dan. Here's an updated patch:
From 0ef1036b57190610577e21a90667c6368e593827 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering@redhat.com> Date: Mon, 10 Aug 2009 12:44:09 +0200 Subject: [PATCH libguestfs] build: enable automake's silent rules option
* configure.ac: Use AM_SILENT_RULES([yes]). Those who want verbose build output may configure with --disable-silent-rules or use "make V=1". * daemon/configure.ac: Likewise. --- configure.ac | 3 +++ daemon/configure.ac | 3 +++ 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/configure.ac b/configure.ac index cf0591d..a78ca51 100644 --- a/configure.ac +++ b/configure.ac @@ -26,6 +26,9 @@ AC_INIT([libguestfs],libguestfs_major.libguestfs_minor.libguestfs_release[]libgu AC_CONFIG_AUX_DIR([build-aux]) AM_INIT_AUTOMAKE([foreign]) +m4_ifndef([AM_SILENT_RULES], [m4_define([AM_SILENT_RULES],[])]) +AM_SILENT_RULES([yes]) # make --enable-silent-rules the default. + AC_CONFIG_MACRO_DIR([m4]) AC_PROG_LIBTOOL diff --git a/daemon/configure.ac b/daemon/configure.ac index b038d17..43e331b 100644 --- a/daemon/configure.ac +++ b/daemon/configure.ac @@ -19,6 +19,9 @@ AC_INIT([libguestfs-daemon],[1.0.0]) AC_CONFIG_AUX_DIR([build-aux]) AM_INIT_AUTOMAKE([foreign]) +m4_ifndef([AM_SILENT_RULES], [m4_define([AM_SILENT_RULES],[])]) +AM_SILENT_RULES([yes]) # make --enable-silent-rules the default. + AC_CONFIG_MACRO_DIR([m4]) dnl If the user specified --enable-32bit, then force the C compiler -- 1.6.4.300.gc9df
On Mon, Aug 10, 2009 at 01:50:33PM +0200, Jim Meyering wrote:
Here's an updated patch:
From 0ef1036b57190610577e21a90667c6368e593827 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering@redhat.com> Date: Mon, 10 Aug 2009 12:44:09 +0200 Subject: [PATCH libguestfs] build: enable automake's silent rules option
* configure.ac: Use AM_SILENT_RULES([yes]). Those who want verbose build output may configure with --disable-silent-rules or use "make V=1". * daemon/configure.ac: Likewise. --- configure.ac | 3 +++ daemon/configure.ac | 3 +++ 2 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/configure.ac b/configure.ac index cf0591d..a78ca51 100644 --- a/configure.ac +++ b/configure.ac @@ -26,6 +26,9 @@ AC_INIT([libguestfs],libguestfs_major.libguestfs_minor.libguestfs_release[]libgu AC_CONFIG_AUX_DIR([build-aux]) AM_INIT_AUTOMAKE([foreign])
+m4_ifndef([AM_SILENT_RULES], [m4_define([AM_SILENT_RULES],[])]) +AM_SILENT_RULES([yes]) # make --enable-silent-rules the default. + AC_CONFIG_MACRO_DIR([m4])
AC_PROG_LIBTOOL diff --git a/daemon/configure.ac b/daemon/configure.ac index b038d17..43e331b 100644 --- a/daemon/configure.ac +++ b/daemon/configure.ac @@ -19,6 +19,9 @@ AC_INIT([libguestfs-daemon],[1.0.0]) AC_CONFIG_AUX_DIR([build-aux]) AM_INIT_AUTOMAKE([foreign])
+m4_ifndef([AM_SILENT_RULES], [m4_define([AM_SILENT_RULES],[])]) +AM_SILENT_RULES([yes]) # make --enable-silent-rules the default. + AC_CONFIG_MACRO_DIR([m4])
dnl If the user specified --enable-32bit, then force the C compiler -- 1.6.4.300.gc9df
I verified this on CentOS 5.3, so ACK. Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into Xen guests. http://et.redhat.com/~rjones/virt-p2v
Richard W.M. Jones wrote:
On Mon, Aug 10, 2009 at 12:47:20PM +0200, Jim Meyering wrote:
Thanks to the reminder from Dan Berrange, here's a patch to make build output less verbose, by default. E.g., instead of the redundant multi-line compilation/linking commands, you'll see something like this by default: +AM_SILENT_RULES([yes]) # make --enable-silent-rules the default.
I tried this one before but it doesn't work on RHEL 5.3:
Dan mentioned the work-around. However, in general, ... Do you want to require that libguestfs be buildable from scratch (clone) on RHEL 5.3 ? That's fine if it's required, but it may put a damper on certain build-related improvements.
On Mon, Aug 10, 2009 at 01:24:20PM +0200, Jim Meyering wrote:
Richard W.M. Jones wrote:
On Mon, Aug 10, 2009 at 12:47:20PM +0200, Jim Meyering wrote:
Thanks to the reminder from Dan Berrange, here's a patch to make build output less verbose, by default. E.g., instead of the redundant multi-line compilation/linking commands, you'll see something like this by default: +AM_SILENT_RULES([yes]) # make --enable-silent-rules the default.
I tried this one before but it doesn't work on RHEL 5.3:
Dan mentioned the work-around.
However, in general, ...
Do you want to require that libguestfs be buildable from scratch (clone) on RHEL 5.3 ?
Yes. I get more mail from external users using RHEL than Fedora, and they often build from source so they can get the extra features we don't ship (ie. virt-inspector). Maybe I get more mail because they have more problems, but RHEL 5.3 built from source / git clone is nevertheless a requirement. Are we planning to rev autotools in RHEL 5.4? That might makes things easier if we do it. Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones Read my programming blog: http://rwmj.wordpress.com Fedora now supports 75 OCaml packages (the OPEN alternative to F#) http://cocan.org/getting_started_with_ocaml_on_red_hat_and_fedora
participants (3)
-
Daniel P. Berrange -
Jim Meyering -
Richard W.M. Jones