Re: [Libguestfs] [PATCH] inspect: Get architecture of Alpine Linux from /bin/busybox.
On Tuesday 26 January 2016 15:54:46 Richard W.M. Jones wrote:
All the files in /bin are links to busybox.
guestfs_file_architecture
doesn't follow symlinks so it fails. Therefore check /bin/busybox
(not a symlink) to find the architecture.
---
While this patch looks okay in principle, I think it would be better
to just resolve the paths we are looking for: that is, do symlink
resolution in is_file, and use realpath to get the actual path before
passing it to file_architecture. If the file can be stat()ed, then it
is a relative symlink whose target we can read.
Patch coming in a minute.
--
Pino Toscano
Attachments:
- signature.asc (application/pgp-signature — 819 bytes)