Re: [Libguestfs] [libnbd PATCH v3 01/10] rust: create basic Rust bindings

Just a note that this patch (I think?) causes this if you don't have rustfmt installed: /bin/sh: line 1: rustfmt: command not found Fatal error: exception Failure("Rustfmt failed with exit code 127") Raised at Stdlib.failwith in file "stdlib.ml", line 29, characters 17-33 Called from Utils.output_to in file "utils.ml", line 432, characters 21-76 Called from Generator in file "generator.ml", line 65, characters 2-88 I don't think rustfmt should be a mandatory dependency of libnbd, so we should probably just treat it as a no-op if rustfmt wasn't found. (See also https://github.com/libguestfs/libguestfs-common/blob/e70d89a58dae068be2e1... ) Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into KVM guests. http://libguestfs.org/virt-v2v