Re: [Libguestfs] [PATCH nbdkit v2 9/9] curl: Redefine connections=<N> parameter as number of HTTP connections

On Fri, Jul 28, 2023 at 06:17:53PM +0100, Richard W.M. Jones wrote: > Previously (nbdkit 1.34) this was the number of easy handles. However > it turns out that easy handles can open multiple HTTP connections, and > in fact there's no good way to tell how many (and they are not > shared). > > Now that we are using a curl multi, curl >= 7.30 provides a way to > limit the total number of actual HTTP connections, so we should just > use it. This is closer to what I intended this parameter to mean. > > Link: https://curl.se/mail/lib-2019-03/0102.html > Link: https://curl.se/mail/lib-2019-12/0044.html > --- > plugins/curl/nbdkit-curl-plugin.pod | 13 +++++++++---- > plugins/curl/curldefs.h | 3 +++ > plugins/curl/config.c | 2 +- > plugins/curl/pool.c | 6 +++++- > 4 files changed, 18 insertions(+), 6 deletions(-) I still want to spend time reviewing 8/9 (even if you check it in first, to get some soak time), but in the short term this one makes obvious sense. Reviewed-by: Eric Blake <eblake(a)redhat.com&gt;