On Mon, Jul 31, 2023 at 04:36:16PM -0500, Eric Blake wrote:
On Fri, Jul 28, 2023 at 06:17:53PM +0100, Richard W.M. Jones wrote:
Previously (nbdkit 1.34) this was the number of easy handles. However it turns out that easy handles can open multiple HTTP connections, and in fact there's no good way to tell how many (and they are not shared).
Now that we are using a curl multi, curl >= 7.30 provides a way to limit the total number of actual HTTP connections, so we should just use it. This is closer to what I intended this parameter to mean.
Link: https://curl.se/mail/lib-2019-03/0102.html Link: https://curl.se/mail/lib-2019-12/0044.html --- plugins/curl/nbdkit-curl-plugin.pod | 13 +++++++++---- plugins/curl/curldefs.h | 3 +++ plugins/curl/config.c | 2 +- plugins/curl/pool.c | 6 +++++- 4 files changed, 18 insertions(+), 6 deletions(-)
I still want to spend time reviewing 8/9 (even if you check it in first, to get some soak time), but in the short term this one makes obvious sense.
Reviewed-by: Eric Blake <eblake@redhat.com>
Thanks - I want to do a bit more testing on the series before I push it. I have put the latest version here: https://gitlab.com/rwmjones/nbdkit/-/commits/2023-curl-multi/ Also for the record this series revealed an actual bug in curl: https://github.com/curl/curl/pull/11557 Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://people.redhat.com/~rjones/virt-top