On Wednesday 30 March 2016 13:45:15 NoxDaFox wrote: Just remember to keep the list in the loop. Indeed it is something that should be changed, since the rest of the code definitely has spaces between functions and opening parenthesis. What I mentioned is the style used all around the code. Prototypes need a single line, while the actual function definitions indented as above. In general, a golden rule that applies whenever patching any software is "follow the existing style", in case there is a single one (or at least one followed in the majority of the codebase). Usually cover letters provide a general overview of what a series of patches does, while the actual commits still provide explanations of what each does. -- Pino Toscano