9:52 a.m.
Just a two things I found out when trying to set up the CI.
Martin Kletzander (2):
Fix reporting of NBD URI support by configure
Add an extra info for ocamlfind dependency
configure.ac | 2 +-
generator/Makefile.am | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
--
2.31.1
9:52 a.m.
New subject: [libnbd PATCH 1/2] Fix reporting of NBD URI support by configure
Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com>
---
configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index 0135c12ec04d..d65b31a63077 100644
--- a/configure.ac
+++ b/configure.ac
@@ -548,7 +548,7 @@ echo
feature "TLS support ............................ " \
test "x$HAVE_GNUTLS_TRUE" = "x"
feature "NBD URI support ........................ " \
- test "x$LIBXML2_LIBS" != "x"
+ test "x$HAVE_LIBXML2_TRUE" = "x"
feature "FUSE support ........................... " \
test "x$HAVE_FUSE_TRUE" = "x"
feature "Manual pages ........................... " \
--
2.31.1
9:52 a.m.
New subject: [libnbd PATCH 2/2] Add an extra info for ocamlfind dependency
Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com>
---
generator/Makefile.am | 1 +
1 file changed, 1 insertion(+)
diff --git a/generator/Makefile.am b/generator/Makefile.am
index 594d23cf53fa..65935e6e330f 100644
--- a/generator/Makefile.am
+++ b/generator/Makefile.am
@@ -96,6 +96,7 @@ stamp-generator:
echo "Source files are missing from your build."; \
echo; \
echo "Install the OCaml bytecode compiler (the program called ‘ocamlc’)";
\
+ echo "and OCaml findlib (program called ocamlfind)"; \
echo "and rerun ./configure && make"; \
echo; \
echo " *** *** ***"; \
--
2.31.1
10:27 a.m.
New subject: [libnbd PATCH 2/2] Add an extra info for ocamlfind dependency
On 3/30/21 9:52 AM, Martin Kletzander wrote:
Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com>
---
generator/Makefile.am | 1 +
1 file changed, 1 insertion(+)
diff --git a/generator/Makefile.am b/generator/Makefile.am
index 594d23cf53fa..65935e6e330f 100644
--- a/generator/Makefile.am
+++ b/generator/Makefile.am
@@ -96,6 +96,7 @@ stamp-generator:
echo "Source files are missing from your build."; \
echo; \
echo "Install the OCaml bytecode compiler (the program called ‘ocamlc’)";
\
+ echo "and OCaml findlib (program called ocamlfind)"; \
Do we want consistent quoting between these two lines?
echo "and rerun ./configure && make";
\
echo; \
echo " *** *** ***"; \
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
10:59 a.m.
New subject: [libnbd PATCH 2/2] Add an extra info for ocamlfind dependency
On Tue, Mar 30, 2021 at 10:27:54AM -0500, Eric Blake wrote:
On 3/30/21 9:52 AM, Martin Kletzander wrote:
> Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com>
> ---
> generator/Makefile.am | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/generator/Makefile.am b/generator/Makefile.am
> index 594d23cf53fa..65935e6e330f 100644
> --- a/generator/Makefile.am
> +++ b/generator/Makefile.am
> @@ -96,6 +96,7 @@ stamp-generator:
> echo "Source files are missing from your build."; \
> echo; \
> echo "Install the OCaml bytecode compiler (the program called
‘ocamlc’)"; \
> + echo "and OCaml findlib (program called ocamlfind)"; \
Do we want consistent quoting between these two lines?
Oh, I could've copy-pasted the fancy quotes, yeah.
> echo "and rerun ./configure && make";
\
> echo; \
> echo " *** *** ***"; \
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
11:39 a.m.
New subject: [libnbd PATCH 2/2] Add an extra info for ocamlfind dependency
On Tue, Mar 30, 2021 at 04:52:06PM +0200, Martin Kletzander wrote:
Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com>
---
generator/Makefile.am | 1 +
1 file changed, 1 insertion(+)
diff --git a/generator/Makefile.am b/generator/Makefile.am
index 594d23cf53fa..65935e6e330f 100644
--- a/generator/Makefile.am
+++ b/generator/Makefile.am
@@ -96,6 +96,7 @@ stamp-generator:
echo "Source files are missing from your build."; \
echo; \
echo "Install the OCaml bytecode compiler (the program called ‘ocamlc’)";
\
+ echo "and OCaml findlib (program called ocamlfind)"; \
This shouldn't be necessary since I added this fix:
https://gitlab.com/nbdkit/libnbd/-/commit/dae04165c35f45bc0d63abebf05a1d9...
The other patch is fine.
Rich.
echo "and rerun ./configure && make";
\
echo; \
echo " *** *** ***"; \
--
2.31.1
_______________________________________________
Libguestfs mailing list
Libguestfs(a)redhat.com
https://listman.redhat.com/mailman/listinfo/libguestfs
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-top is 'top' for virtual machines. Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://people.redhat.com/~rjones/virt-top
4:22 p.m.
New subject: [libnbd PATCH 2/2] Add an extra info for ocamlfind dependency
On Tue, Mar 30, 2021 at 05:39:50PM +0100, Richard W.M. Jones wrote:
On Tue, Mar 30, 2021 at 04:52:06PM +0200, Martin Kletzander wrote:
> Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com>
> ---
> generator/Makefile.am | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/generator/Makefile.am b/generator/Makefile.am
> index 594d23cf53fa..65935e6e330f 100644
> --- a/generator/Makefile.am
> +++ b/generator/Makefile.am
> @@ -96,6 +96,7 @@ stamp-generator:
> echo "Source files are missing from your build."; \
> echo; \
> echo "Install the OCaml bytecode compiler (the program called
‘ocamlc’)"; \
> + echo "and OCaml findlib (program called ocamlfind)"; \
This shouldn't be necessary since I added this fix:
https://gitlab.com/nbdkit/libnbd/-/commit/dae04165c35f45bc0d63abebf05a1d9...
Oh, ok, the patch I sent is pretty old, I just forgot about it. We'll
also have a rough check for minimal requirements after we add more
things to the CI in order to build minimal requirements.
The other patch is fine.
Rich.
> echo "and rerun ./configure && make"; \
> echo; \
> echo " *** *** ***"; \
> --
> 2.31.1
>
> _______________________________________________
> Libguestfs mailing list
> Libguestfs(a)redhat.com
> https://listman.redhat.com/mailman/listinfo/libguestfs
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-top is 'top' for virtual machines. Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://people.redhat.com/~rjones/virt-top
1365
days inactive
1365
days old
6 comments
3 participants
participants (3)
-
Eric Blake -
Martin Kletzander -
Richard W.M. Jones