Re: [Libguestfs] [External] Re: [PATCH] VxFS Filesystem support to libguestfs

Hi Richard, Thank you for making these changes. We appreciate your insights. We will promptly address the issues you have mentioned, thoroughly test them. We will keep you updated and send you the patch once we have completed the testing. Thanks, Ravi/Gaurang ________________________________ From: Richard W.M. Jones <rjones(a)redhat.com&gt; Sent: Tuesday, September 19, 2023 4:30 PM To: Ravi Singh <Ravi.Singh(a)veritas.com&gt; Cc: libguestfs(a)redhat.com <libguestfs(a)redhat.com>; Aswad Kulkarni <aswad.kulkarni(a)veritas.com>; Shailesh Marathe <Shailesh.Marathe(a)veritas.com>; Sumit Dighe <Sumit.Dighe(a)veritas.com>; Mitul Kothari <Mitul.Kothari(a)veritas.com>; Brad Boyer <brad.boyer(a)veritas.com>; Saket Pusalkar <Saket.Pusalkar(a)veritas.com>; Gaurang Agnihotri <Gaurang.Agnihotri(a)veritas.com>; Satyajit Gorhe parlikar <Satyajit.Gorheparlik(a)veritas.com>; John Cronin <john.cronin(a)veritas.com&gt; Subject: Re: [External] Re: [Libguestfs] [PATCH] VxFS Filesystem support to libguestfs CAUTION: This email originated from outside the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe. If you believe this is a phishing email, use the Report to Cybersecurity icon in Outlook. A new patch is attached. This is only build tested so far. To build with this patch I had to do: ./configure --enable-werror \ --with-supermin-packager-config=$PWD/localyum.conf where localyum.conf contains: ---------------------------------------------------------------------- [local] name=local baseurl=file:///root/dvd1-redhatlinux/rhel9_x86_64/rpms/ enabled=1 gpgcheck=0 ---------------------------------------------------------------------- (adjust the path to point to the Veritas DVD mount point) I made various changes in this patch: - Add copyright and license notice to list_vxvm.ml & vxfs.c. Please ensure all files have copyright and license notices, and if necessary get them checked by your legal. - Change vm.ml{,i} -> list_vxvm.ml{,i} - In packagelist.in, move package names to their own section. - Remove perl/python packages as perl/python is not present in the appliance. - Fix commit message. - Line length under 80 columns in a few places. - Function names at start of line. - List SOURCES_MLI alphabetically. - daemon/listfs.ml: Remove comment about has_vxvm. - do_vxfs_start -> vxfs_start (since do_* is reserved prefix in daemon). - Skip vxfs_start if !vxdisk available, to save start up time. - Add a prototype for vxfs_start. - Don't use reply_with_error in vxfs_start, as we're not called during protocol context. - Use only one *err. - Add daemon/list_vxvm.mli & daemon/vxvm_type.mli to .gitignore vxfs_start has several issues which need to be addressed: - Why does it return if a service (eg. veki) is not available? That would prevent all further initialization. - I think this would be better done as part of appliance/init, and delete this function completely. Rich. -- Richard Jones, Virtualization Group, Red Hat https://nam12.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpeople.r... Read my programming and virtualization blog: https://nam12.safelinks.protection.outlook.com/?url=http%3A%2F%2Frwmj.wor... libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages. https://nam12.safelinks.protection.outlook.com/?url=http%3A%2F%2Flibguest...