Re: [Libguestfs] [PATCH] Added --use-installed switch (which for now only works for Debian).
On Thu, Sep 22, 2011 at 08:55:30PM +0200, Hilko Bengen wrote:
+ let files = (ph.ph_list_files ~use_installed:use_installed
pkg) in
In OCaml,
f ~a:a
can be (and normally is) abbreviated to:
f ~a
so you can just write 'ph.ph_list_files ~use_installed pkg' here.
+(* fixme: use_installed *)
+let pacman_list_files ?(use_installed=false) pkg =
Instead of the comment, I'd prefer:
let pacman_list_files ?(use_installed=false) pkg =
if use_installed then
failwith "pacman driver doesn't support --use-installed";
...rest...
Also this needs an addition to febootstrap.pod (the man page).
Apart from those things, the patch looks good.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine. Supports Linux and Windows.
http://et.redhat.com/~rjones/virt-df/