Re: [Libguestfs] [PATCH] rhv-upload: Support qcow2 disks

On Mon, Nov 25, 2019 at 04:27:11PM +0200, Nir Soffer wrote: > On Mon, Nov 25, 2019, 11:15 Richard W.M. Jones <rjones(a)redhat.com&gt; wrote: > > > On Wed, Nov 20, 2019 at 03:06:55AM +0200, Nir Soffer wrote: > > > diff --git a/v2v/v2v.ml b/v2v/v2v.ml > > > index 03590c9e..58bb06c3 100644 > > > --- a/v2v/v2v.ml > > > +++ b/v2v/v2v.ml > > > @@ -739,7 +739,9 @@ and copy_targets cmdline targets input output = > > > | TargetURI uri -> uri in > > > [ "qemu-img"; "convert" ] @ > > > (if not (quiet ()) then [ "-p" ] else []) @ > > > - [ "-n"; "-f"; "qcow2"; "-O"; t.target_format ] @ > > > + (* XXX When using NBD we must use raw format, not the > > target_format > > > + * which is the disk format. commpressed format will also not > > work. *) > > > + [ "-n"; "-f"; "qcow2"; "-O"; "raw" ] @ > > > > This is going to break all the other output modes. > > > > You probably want to define a new method output#override_output_format > > (see v2v.ml:get_target_formats and types.mli). > > > > Maybe outpu#tranfer_format? > Return output_format by default, rhv_output will override it to return raw? Isn't that essentially what #override_output_format virtual method does already?

Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://people.redhat.com/~rjones/virt-top