Re: [Libguestfs] [PATCH 0/4] v2v: simplify driver copying from virtio-win iso
On Tue, Oct 06, 2015 at 02:51:46PM +0100, Richard W.M. Jones wrote:
On Tue, Oct 06, 2015 at 02:12:03PM +0100, Richard W.M. Jones wrote:
> Why don't we just use the second handle. The real issue is why the
> handle isn't being cleaned up by the GC, which may reveal some deeper
> bug somewhere. I only had a brief look at this.
I'm able to reproduce this in a minimal program. Still investigating.
Fixed, see:
https://www.redhat.com/archives/libguestfs/2015-October/msg00082.html
and I've tested that virt-v2v with this patch series closes the second
handle when Gc.compact () is called.
Thanks for noticing this bug!
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-builder quickly builds VMs from scratch
http://libguestfs.org/virt-builder.1.html