Re: [Libguestfs] [PATCH v11 02/10] daemon: Embed the ocaml-augeas library in the daemon.
On Tue, Aug 08, 2017 at 06:57:33PM +0200, Pino Toscano wrote:
On Monday, 31 July 2017 17:40:51 CEST Richard W.M. Jones wrote:
> This commit embeds the ocaml-augeas library (upstream here:
> http://git.annexia.org/?p=ocaml-augeas.git;a=summary). It's identical
> to the upstream version and should remain so.
>
> We can work towards using system ocaml-augeas, when it's more widely
> available.
> ---
> daemon/Makefile.am | 3 +
> daemon/augeas-c.c | 288 +++++++++++++++++++++++++++++++++++++++++++++++++++
> daemon/augeas.README | 8 ++
> daemon/augeas.ml | 59 +++++++++++
> daemon/augeas.mli | 95 +++++++++++++++++
> daemon/daemon-c.c | 2 +
> docs/C_SOURCE_FILES | 1 +
> 7 files changed, 456 insertions(+)
Would it be possible to place it in a subdirectory? This way it's easier
to compare it with the upstream version, and maybe easily not built when
using a system version.
Yes - that's a good idea. In fact in a later evolution of this series
I put it in common/mlaugeas.
Once I've looked at your other review comments I'll post the new
version containing this change.
Thanks,
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-top is 'top' for virtual machines. Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://people.redhat.com/~rjones/virt-top