Re: [Libguestfs] [PATCH] Fix, simplify out-of-tree build/install for bash completions
On Friday 31 October 2014 20:03:22 Hilko Bengen wrote:
@@ -87,10 +59,14 @@ if HAVE_BASH_COMPLETION
bashcompletiondir = $(BASH_COMPLETIONS_DIR)
#bashcompletion_DATA = $(scripts)
-all-local: $(scripts)
+all-local: $(scripts) $(symlinks)
+ test $(srcdir) != $(builddir) && cd $(srcdir) && cp $(scripts)
$(abs_builddir)/
-install-data-local: $(scripts)
+install-data-local:
$(mkdir_p) $(DESTDIR)$(bashcompletiondir)
- cp -d $(scripts) $(DESTDIR)$(bashcompletiondir)
+ cp -d $(scripts) $(symlinks) $(DESTDIR)$(bashcompletiondir)
+
+clean-local:
+ test $(srcdir) != $(builddir) && rm -f $(symlinks) $(scripts)
This however breaks when srcdir==builddir. I'm sending a followup to
hopefully fix this. Maybe just creating the symlinks only in the
installation directory would not have been a bad idea...
--
Pino Toscano