On Thu, Aug 13, 2009 at 05:07:36PM +0200, Jim Meyering wrote:
Looks fine. But why not do the same for tgz_in ?
tgz_in is a FileIn parameter, and those functions have to be handled
quite differently. In particular you can't call reply_with{,p}error
for those functions -- you have to cancel the receive first. This is
not really documented anywhere ...
http://libguestfs.org/guestfs.3.html#functions_that_have_filein_parameters
The upshot is that any functions which have any FileIn parameter must
not use Pathname/Device/Dev_or_path, but must do all the checking
explicitly.
Luckily there are only 3 or 4 such functions.
Rich.
--
Richard Jones, Emerging Technologies, Red Hat
http://et.redhat.com/~rjones
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine. Supports Linux and Windows.
http://et.redhat.com/~rjones/virt-df/