Re: [Libguestfs] [nbdkit PATCH v2 15/17] sh: Enable parallel thread model, when possible
On Fri, Aug 02, 2019 at 03:27:06PM -0500, Eric Blake wrote:
Makes sense. So the change will be:
- compile-time THREAD_MODEL = PARALLEL (necessary, as otherwise a
script can't request parallel)
- if script declares .thread_model, then use that mode (any mode
possible, whereas older nbdkit silently downgrades parallel to
serialize_all_requests per the older compile-time max)
- if script does not declare .thread_model, then use
SERIALIZE_ALL_REQUESTS (matching historical behavior)
This seems better to me.
I really think removing (not adding) the fork flag is better, and
instead forcing platforms that don't support atomic CLOEXEC to
serialize requests.
ACK series.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW