Re: [Libguestfs] [PATCH V3] virt-sysprep:add ipconfig for preparation

On Wed, Mar 14, 2012 at 08:41:01PM +0800, Wanlong Gao wrote: The quoting here is still (not actually) wrong, but I think we should quote it. See my previous comment: https://www.redhat.com/archives/libguestfs/2012-March/msg00048.html "Apparently you don't need to quote parameters in bash, but while this is technically correct, I think it is safer to quote it. There are a few other similar ones later in the code." But, if you add the right quoting, this patch will be fine and I will push it. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into Xen guests. http://et.redhat.com/~rjones/virt-p2v