Re: [Libguestfs] [PATCH 2/2] Remove sound cards when outputting to libvirt

As we can't currently detect what sound card models are supported by the target hypervisor, simply remove them. Works round RHBZ#589567 --- lib/Sys/VirtV2V/Target/LibVirt.pm | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/lib/Sys/VirtV2V/Target/LibVirt.pm b/lib/Sys/VirtV2V/Target/LibVirt.pm index 95ffad4..029e4e2 100644 --- a/lib/Sys/VirtV2V/Target/LibVirt.pm +++ b/lib/Sys/VirtV2V/Target/LibVirt.pm @@ -344,7 +344,13 @@ sub _unconfigure_incompatible_devices # We have replaced the SCSI controller with either VirtIO or IDE. # Additionally, attempting to start a guest converted from ESX, which # has an lsilogic SCSI controller, will fail on RHEL 5. - $dom->findnodes("/domain/devices/controller[\@type='scsi']") + $dom->findnodes("/domain/devices/controller[\@type='scsi']"), + + # XXX: We have no current way of detecting which sound card models are + # supported by the target hypervisor. As an unsupported sound card model + # can prevent the guest from starting, we simply remove sound cards for + # the moment. + $dom->findnodes("/domain/devices/sound") ) { $path->getParentNode()->removeChild($path);