Re: [Libguestfs] [PATCH nbdkit] valgrind: Don't call dlclose when running under valgrind.
On 07/01/2018 10:01 AM, Richard W.M. Jones wrote:
On Sun, Jul 01, 2018 at 12:50:46PM +0100, Richard W.M. Jones wrote:
> diff --git a/src/Makefile.am b/src/Makefile.am
> index 7ead75c..915efe4 100644
> --- a/src/Makefile.am
> +++ b/src/Makefile.am
> @@ -63,7 +63,8 @@ nbdkit_CPPFLAGS = \
> nbdkit_CFLAGS = \
> -pthread \
> $(WARNINGS_CFLAGS) \
> - $(GNUTLS_CFLAGS)
> + $(GNUTLS_CFLAGS) \
> + $(VALGRIND_CFLAGS)
Just a note that this also has to be added to test_utils_CFLAGS at the
bottom of the same file, otherwise the tests fail to compile.
With that fix, ACK.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org