Re: [Libguestfs] [libnbd PATCH] copy: Fail nbdcopy if NBD read or write fails
On 02/08/22 14:43, Richard W.M. Jones wrote:
On Fri, Feb 04, 2022 at 09:18:07AM +0100, Laszlo Ersek wrote:
> (And there was no easy way to skip connect-tcp6.)
Wwe use this in libnbd.spec:
https://src.fedoraproject.org/rpms/libnbd/blob/rawhide/f/libnbd.spec#_214
Yes (I know what the link points to, without looking :)); that's why one
of my earlier patches (or patch sets) exposed the real issue in it only
in Brew! :)
In libguestfs we have a whole infrastructure for skipping tests by
setting $SKIP_* variables in localenv.
https://libguestfs.org/guestfs-building.1.html#local-files
Ah, this is very nice.
For the various v2v projects, I've created a bunch of env setup scripts,
and those scripts consider the inter-project dependencies (based on the
graph you gave me earlier). So they more or less "chain" the various
"run" scripts in the project roots.
One problem with the ignored local* files in the git worktrees could be
that "git clean -ffdx" probably removes them. I have a $HOME/bin/scripts
dir on my $PATH, where I keep such scripts.
https://github.com/libguestfs/libguestfs/blob/0553f90462f456b1fe7100346aa...
For libnbd/nbdkit it might be possible to automate it in the same way
with tests/functions.sh.in + $0, but it's not implemented at the
moment. Of course it'd be better if the tests didn't fail :-)
Yes, absolutely.
Thanks!
Laszlo