Re: [Libguestfs] [PATCH 2/4] p2v: fix dependencies for SLES / openSUSE

Use the common denominator for SLES and openSUSE in the dependencies. For example most of NetworkManager pieces and metacity aren't provided on SLES. ifconfig is in the net-tools-deprecated package in openSUSE Factory, which means after openSUSE Leap 42.2. Older versions have it in the net-tools package. Adding this complexity only to add ifconfig because sysadmins prefer it isn't too good: iproute2 is doing the job. --- p2v/dependencies.m4 | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/p2v/dependencies.m4 b/p2v/dependencies.m4 index 635e253..fd20ddd 100644 --- a/p2v/dependencies.m4 +++ b/p2v/dependencies.m4 @@ -119,8 +119,8 @@ ifelse(SUSE,1, pcre libxml2 gtk`'GTK_VERSION - /usr/bin/ssh - /usr/bin/qemu-nbd + qemu-tools + openssh curl ethtool hwdata @@ -129,14 +129,15 @@ ifelse(SUSE,1, smartmontools util-linux xterm - /usr/bin/xinit - /usr/bin/Xorg + xinit + xorg-x11-server xf86-video-* dejavu-fonts - metacity NetworkManager - nm-connection-editor - network-manager-applet - dbus-x11 - net-tools-deprecated + xf86-input-* + icewm-lite + dbus-1-x11 + yast2-network + libyui-qt + SuSEfirewall2 ) --