Re: [Libguestfs] [libnbd PATCH] ci: Enable python code style

On Tue, Jun 22, 2021 at 9:20 PM Martin Kletzander <mkletzan(a)redhat.com&gt; wrote: I think this is intentionally optional since the version of flake8 or installed plugins can cause build failures. See: https://mail.google.com/mail/u/0/#inbox Python code style should not be part of the build. This is should be used in CI environment or by developers locally, but not when building packages (in case this script is used for building packages). To enable flake8 (and similar tools) the build environment must enforce specific version of the tool. Otherwise you may get unexpected failures when flake8 folks change the rules from version to version. We solve this in ovirt using tox, installing a specific version of flake8: https://github.com/oVirt/vdsm/blob/d7057084fe51dc26811c1ec0ee738ad2314e90... https://github.com/oVirt/ovirt-imageio/blob/master/daemon/tox.ini#L26