[Libguestfs] [PATCH libnbd v2 2/3] generator: Set SO_NOSIGPIPE on sockets

If the platform supports it, set the SO_NOSIGPIPE socket option on sockets that we create in nbd_connect_* functions (except nbd_connect_socket where the caller gets to choose). Link: https://www.doof.me.uk/2020/09/23/sigpipe-and-how-to-ignore-it/ --- generator/states-connect.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/generator/states-connect.c b/generator/states-connect.c index 8de12183d6..8a286e6630 100644 --- a/generator/states-connect.c +++ b/generator/states-connect.c @@ -45,6 +45,21 @@ disable_nagle (int sock) setsockopt (sock, IPPROTO_TCP, TCP_NODELAY, &flag, sizeof flag); } +/* Disable SIGPIPE on FreeBSD & MacOS. + * + * Does nothing on other platforms, but if those platforms have + * MSG_NOSIGNAL then we will set that when writing. (FreeBSD has both.) + */ +static void +disable_sigpipe (int sock) +{ +#ifdef SO_NOSIGPIPE + const int flag = 1; + + setsockopt (sock, SOL_SOCKET, SO_NOSIGPIPE, &flag, sizeof flag); +#endif +} + STATE_MACHINE { CONNECT.START: sa_family_t family; @@ -65,6 +80,7 @@ STATE_MACHINE { } disable_nagle (fd); + disable_sigpipe (fd); r = connect (fd, (struct sockaddr *) &h->connaddr, h->connaddrlen); if (r == 0 || (r == -1 && errno == EINPROGRESS)) @@ -177,6 +193,7 @@ STATE_MACHINE { } disable_nagle (fd); + disable_sigpipe (fd); if (connect (fd, h->rp->ai_addr, h->rp->ai_addrlen) == -1) { if (errno != EINPROGRESS) { -- 2.37.0.rc2