Re: [Libguestfs] [PATCH nbdkit v2 4/4] server: debug: Escape debug strings

Then, in the post-patch version, the following catches my eye: fp_inner = open_memstream (&str_inner, &len_inner); if (fp_inner == NULL) { fail: /* Try to emit what we can. */ errno = err; vfprintf (stderr, fs, args); fprintf (stderr, "\n"); return; } errno = err; vfprintf (fp_inner, fs, args); Here a common "errno = err" assignment can be factored out, placed just after the "fp_inner" assignment. But this isn't really relevant, as fixing problem (2) -- i.e., moving "fail" at the end of the function -- might reorder the code such that this code extraction is no longer needed or possible.