Re: [Libguestfs] [xml] Why does libxml2 limit port numbers to 999, 999, 999?
On Oct 17, 2020, at 12:24 , Richard W.M. Jones via xml <xml(a)gnome.org> wrote:
It seems like libxml2 chose to do this for convenience rather than
correctness.
Yes, this is an arbitrary limit introduced to avoid integer overflow.
I think it should accept port numbers at least up to
signed int (the type used to store port numbers), and give an error if
the port number overflows.
This is fixed now:
https://gitlab.gnome.org/GNOME/libxml2/-/commit/b46016b8705b041c0678dd45e...
Also could the uri->port field be changed to unsigned int without
breaking ABI?
It’s a public struct member, so strictly speaking, no. But the risk to break stuff seems
low.
Nick