[Libguestfs] [PATCH] v2v: -o vdsm, -o rhev: Don't create compat=0.10 images;

Support for RHEV with RHEL 6 nodes required us to output the old style qcow2 compat=0.10 images. Since RHEV 3.6 GA, RHEL 6 has not been supported as a RHEV node type. There are significant downsides to using qcow2 compat=0.10 instead of the modern default (compat=1.1), so stop forcing compat=0.10 for these targets. Thanks: Yaniv Kaul, Michal Skrivanek. --- v2v/output_rhev.ml | 4 ---- v2v/output_vdsm.ml | 10 ---------- 2 files changed, 14 deletions(-) diff --git a/v2v/output_rhev.ml b/v2v/output_rhev.ml index e45043b..3280150 100644 --- a/v2v/output_rhev.ml +++ b/v2v/output_rhev.ml @@ -248,10 +248,6 @@ object Changeuid.func changeuid_t ( fun () -> let g = open_guestfs ~identifier:"rhev_disk_create" () in - (* For qcow2, override v2v-supplied compat option, because RHEL 6 - * nodes cannot handle qcow2 v3 (RHBZ#1145582). - *) - let compat = if format <> "qcow2" then compat else Some "0.10" in g#disk_create ?backingfile ?backingformat ?preallocation ?compat ?clustersize path format size; (* Make it sufficiently writable so that possibly root, or diff --git a/v2v/output_vdsm.ml b/v2v/output_vdsm.ml index 7cd94c0..92ce5c0 100644 --- a/v2v/output_vdsm.ml +++ b/v2v/output_vdsm.ml @@ -145,16 +145,6 @@ object (* Return the list of targets. *) targets - method disk_create ?backingfile ?backingformat ?preallocation ?compat - ?clustersize path format size = - let g = open_guestfs ~identifier:"vdsm_disk_create" () in - (* For qcow2, override v2v-supplied compat option, because RHEL 6 - * nodes cannot handle qcow2 v3 (RHBZ#1145582). - *) - let compat = if format <> "qcow2" then compat else Some "0.10" in - g#disk_create ?backingfile ?backingformat ?preallocation ?compat - ?clustersize path format size - (* This is called after conversion to write the OVF metadata. *) method create_metadata source targets _ guestcaps inspect target_firmware = (* See #supported_firmware above. *) -- 2.10.2