Re: [Libguestfs] [PATCH v4 1/3] v2v: refactor copy_drivers() in Windows_virtio
On Tue, 13 Nov 2018 17:34:59 +0000
"Richard W.M. Jones" <rjones(a)redhat.com> wrote:
On Tue, Nov 13, 2018 at 01:41:40PM +0100, Tomáš Golembiovský wrote:
> + List.length (
> + copy_from_virtio_win g inspect "/" driverdir
virtio_iso_path_matches_guest_os
> + ) > 0
Any reason not to change this to copy_from_virtio_win ... <> []
as described in the previous comment on this patch?
None. I just forgot. Along with all the other comments...
I will update the patch and resend.
Tomas
More comments here:
https://www.redhat.com/archives/libguestfs/2018-November/msg00081.html
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine. Supports Linux and Windows.
http://people.redhat.com/~rjones/virt-df/
--
Tomáš Golembiovský <tgolembi(a)redhat.com>