Re: [Libguestfs] [PATCH v4 0/3] libguestfs: guestfs_list_filesystems: skip block devices which cannot hold file system
On Mon, Mar 12, 2018 at 09:01:57AM +0200, Mykola Ivanets wrote:
Rebased.
The only thing left unclear is: "Would you like to document behavior for non-MBR
partitions
more clearly or keep previous implementation despite MBR partition type doesn't make
sense
for non-MBR partitions at all?"
https://gb.redhat.com/archives/libguestfs/2018-February/msg00027.html
I don't agree that the existing implementation doesn't make sense for
GPT. It returns "primary", but the reimplementation returns an error.
That's going to break callers who weren't careful about only using
this API on MBR, and I think that is unnecessary breakage. GPT
partitions are all "primary".
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines. Supports shell scripting,
bindings from many languages. http://libguestfs.org