On 8/16/19 1:01 PM, Eric Blake wrote:
On 8/16/19 12:08 PM, Eric Blake wrote:
> Implementing extents requires some coordination for the Rust code to
> call back into libnbdkit; I'm not familiar with Rust enough to do
> that. But with placeholders for those slots, implementing
> can_cache/cache is trivial. This improves the situation mentioned in
> commit 031fae85.
>
> Signed-off-by: Eric Blake <eblake(a)redhat.com>
> ---
And of course, if you want to actually implement extents, and figure
out
how to expose C-based nbdkit functions to be called by Rust code, be my
guest (for .zero, we need nbdkit_set_error(), for extents, we need
nbdkit_add_extent(), and then we have several other utility functions
like nbdkit_realpath() that could be useful).
Also, we are lacking a tests/*rust* usage; it would be nice if 'make
check' covered a Rust plugin (more than just running 'nbdkit
plugins/rust/target/release/examples/libramdisk.so').
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization:
qemu.org |
libvirt.org