Re: [Libguestfs] [PATCH] daemon: proto: Remove pervasive but useless debugging messages.
On Monday, 9 October 2017 18:20:53 CEST Richard W.M. Jones wrote:
If you spend your time looking at libguestfs debugging output
you'll
see many messages from the daemon main loop like this:
guestfsd: main_loop: new request, len 0x54
guestfsd: main_loop: proc 278 (mkfs) took 0.02 seconds
I don't think these messages really bring much value. This commit
removes them entirely.
TBH these information were useful to me in the past:
a) the request length made me discover that a locally generated file,
uploaded to the guest with copy/copy_in, was way too bigger than
it was supposted to me
b) the timing information is actually helpful to diagnose slow API
calls (hello, vmware-uninstall-tools.pl)
An alternative might be to change them to make them shorter and/or
less useless, but I'm not sure what that would be.
Unfortunately I don't have alternative solution, I'm afraid. The only
bit that I never used was the proc number, since its name is way more
helpful.
--
Pino Toscano
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)