[libnbd PATCH] rust: Avoid compiler warning about unused import
by Eric Blake
On Fedora 39, cargo 1.75.0 complained:
Compiling libnbd v0.1.0 (/home/eblake/libnbd/rust)
error: unused import: `async_bindings::*`
--> src/lib.rs:31:9
|
31 | pub use async_bindings::*;
| ^^^^^^^^^^^^^^^^^
|
note: the lint level is defined here
--> src/lib.rs:18:9
|
18 | #![deny(warnings)]
| ^^^^^^^^
= note: `#[deny(unused_imports)]` implied by `#[deny(warnings)]`
error: could not compile `libnbd` (lib) due to previous error
Since the presence of async_bindings is itself conditional on tokio,
it doesn't hurt to silence that particular warning.
Signed-off-by: Eric Blake <eblake(a)redhat.com>
---
I don't know enough Rust to know if it would instead be better to just
delete the problematic 'pub use async_bindings::*;' line altogether;
when I did that locally, things still built and passed 'make check'
for me, but I don't know if that's because I don't have tokio
installed correctly.
Hence, I have not pushed this yet, but will wait for a review.
rust/src/lib.rs | 1 +
1 file changed, 1 insertion(+)
diff --git a/rust/src/lib.rs b/rust/src/lib.rs
index 1e1ca2ed..6904ddad 100644
--- a/rust/src/lib.rs
+++ b/rust/src/lib.rs
@@ -27,6 +27,7 @@ mod handle;
pub mod types;
#[allow(unused)]
mod utils;
+#[allow(unused)]
#[cfg(feature = "tokio")]
pub use async_bindings::*;
#[cfg(feature = "tokio")]
--
2.43.0
6 months, 2 weeks
- 3
- 5
libnbd | Failed pipeline for master | bd44b763
by GitLab
Pipeline #1132624696 has failed!
Project: libnbd ( https://gitlab.com/nbdkit/libnbd )
Branch: master ( https://gitlab.com/nbdkit/libnbd/-/commits/master )
Commit: bd44b763 ( https://gitlab.com/nbdkit/libnbd/-/commit/bd44b763fa8011d66e9956d7ddfde43... )
Commit Message: rust: Avoid compiler warning about unused impor...
Commit Author: Eric Blake ( https://gitlab.com/ebblake )
Pipeline #1132624696 ( https://gitlab.com/nbdkit/libnbd/-/pipelines/1132624696 ) triggered by Eric Blake ( https://gitlab.com/ebblake )
had 1 failed job.
Job #5896216156 ( https://gitlab.com/nbdkit/libnbd/-/jobs/5896216156/raw )
Stage: builds
Name: x86_64-freebsd-12
--
You're receiving this email because of your account on gitlab.com.
6 months, 2 weeks
- 1
- 0
ANNOUNCE: libguestfs 1.52, guestfs-tools 1.52, virt-v2v 2.4 - stable releases
by Richard W.M. Jones
I'm pleased to announce the stable releases of libguestfs 1.52,
guestfs-tools 1.52 and virt-v2v 2.4.
Libguestfs (https://libguestfs.org/) is a library for accessing and
modifying virtual machine (VM) disk images.
Guestfs tools is a set of command line tools like virt-customize and
virt-edit built on top of libguestfs for manipulating disk images.
Virt-v2v is a tool for converting virtual machines from VMware and
some other systems, to qemu/KVM. It is also built on top of libguestfs.
The last stable releases of these projects were in early 2023, so the
new stable releases represent about a year of work, from about a dozen
collaborators. The release notes are attached to this email, or you
can read them online here:
https://libguestfs.org/guestfs-release-notes-1.52.1.html
https://libguestfs.org/guestfs-tools-release-notes-1.52.1.html
https://libguestfs.org/virt-v2v-release-notes-2.4.1.html
The releases are available to download from:
https://download.libguestfs.org/
Rich.
----------------------------------------------------------------------
RELEASE NOTES FOR LIBGUESTFS 1.52
These are the release notes for libguestfs stable release 1.52. This
describes the major changes since 1.50.
Libguestfs 1.52.0 was released on 5 January 2024.
Language bindings
The Python bindings now use "bytes" (instead of "str") for the event
callback message, since it may contain arbitrary 8 bit data (thanks
Yonatan Shtarkman).
Also in the Python bindings, fix a rare crash, and avoid memory leaks
in event callbacks (thanks Yonatan Shtarkman, Laszlo Ersek, Eric
Blake).
Support for OCaml 5, and OCaml ≥ 4.07 is now the minimum (thanks
Guillaume Munch‐Maccagnoni, Jerry James, Josh Berdine, Jürgen Hötzel,
Vincent Laviron).
The OCaml bindings now release the runtime lock around calls to
"guestfs_close", since that call might be long‐running (for example it
might have to shut down the appliance and synch disks).
Inspection
Support OpencloudOS (cunshunxia@tencent).
API
SELinux relabelling now runs in parallel, meaning it’s a lot quicker
(Andrey Drobyshev).
Add support for lzma and zstd compression methods in tar APIs (like
"guestfs_tar_in") (Zixun LI).
"guestfs_pvs_full" previously didn’t always return the correct device
names. This has now been fixed.
"guestfs_btrfs_filesystem_balance" fixed so it now works with more
modern btrfs tools (Jürgen Hötzel).
Tools
The guestfish(1) --key option now recognizes LVM names like
/dev/mapper/rhel_bootp--73--75--123-root (Laszlo Ersek).
guestfish --key option also supports a new --key all:... selector to
try the same key on all devices.
In guestmount(1) avoid calling fclose(NULL) on error paths, which might
have caused a crash on some platforms.
Build changes
The "RELEASES" file (which listed release dates) has been removed and
replaced with a simple "RELEASE_DATE" macro in ./configure. This
should simplify builds.
Optionally passt(1) may be used for networking (Laszlo Ersek).
dhcpcd(8) is now used in preference to dh‐client on Red Hat platforms.
Old Ruby "MiniTest" and "Test::Unit" dependencies replaced with new
"Minitest".
Fix compatibility issues with libxml2 2.12.
Internals
On x86-64 we now use the more modern q35 machine type when running the
appliance. This should perform slightly better and has more
development attention from the qemu community. The change should be
invisible to libguestfs users.
Fix a segmentation fault when "TERM" environment variable was set to
"dumb" (Daisuke HATAYAMA).
Avoid a warning on modern Fedora which does not have /selinux (Andrey
Drobyshev).
Fix build on OpenSUSE LEAP 15 or other distros with a file(1) command
which did not understand the -S option (thanks Olaf Hering).
Bugs fixed
https://bugzilla.redhat.com/2247057
Remove dependency on dhcp‐client in libguestfs
https://bugzilla.redhat.com/2184967
RFE: support passt for appliance networking, as QEMU userspace
networking backend
https://bugzilla.redhat.com/2168578
use q35 machine type for libguestfs appliance
https://bugzilla.redhat.com/1910039
virt‐dib doesn’t work with newer diskimage‐builder version on RHEL8
SEE ALSO
guestfs-examples(1), guestfs-faq(1), guestfs-performance(1),
guestfs-recipes(1), guestfs-testing(1), guestfs(3), guestfish(1),
http://libguestfs.org/
AUTHORS
Andrey Drobyshev
cunshunxia
Emilio Herrera
grimst
HATAYAMA Daisuke
Jan Kuparinen
Jürgen Hötzel
Laszlo Ersek
Pavel Borecki
Richard W.M. Jones
Temuri Doghonadze
Tian Shixiong
Yuri Chornoivan
Zixun LI
RELEASE NOTES FOR GUESTFS TOOLS 1.52
These are the release notes for guestfs tools stable release 1.52.
This describes the major changes since 1.50.
Guestfs tools 1.52.0 was released on 5 January 2024.
virt‐dib was removed
virt‐dib, a tool that built disk images using diskimage‐builder
descriptions has been removed. It only supported an older version of
the diskimage‐builder metadata. See also:
https://bugzilla.redhat.com/1910039
virt‐builder
virt-builder(1) now prints better error messages when a specific URL
cannot be downloaded.
virt‐builder‐repository
Fix GPG repository signing (thanks Allard Berends).
virt‐customize
New virt-customize(1) --chown and --tar-in options. (Also available in
virt‐builder and virt‐sysprep.)
virt‐diff
virt-diff(1) no longer considers "st_dev" and "st_ino" fields, which
means that guests where a file has moved across a mountpoint but is
otherwise identical (size, path, etc) will not show up as a difference.
virt‐drivers
virt-drivers(1) a tool which looks at the device drivers needed by a
guest, can now look up vendor and device names using the PCI and USB
IDs databases.
Common changes
The common --key option now recognizes LVM names like
/dev/mapper/rhel_bootp--73--75--123-root (Laszlo Ersek).
The --key option also supports a new --key all:... selector to try the
same key on all devices.
Build changes
Support for OCaml 5, and OCaml ≥ 4.07 is now the minimum (thanks
Guillaume Munch‐Maccagnoni, Jerry James, Josh Berdine, Jürgen Hötzel,
Vincent Laviron).
Fix compatibility issues with libxml2 2.12.
Internals
Fix an off‐by‐one error which caused very rare crashes in some of the
virt tools.
Bugs fixed
https://bugzilla.redhat.com/2175703
virt-v2v failed to inspect RHEL9.2 guest due to kernel‐core /
kernel‐modules‐core subpackage split
https://bugzilla.redhat.com/2168506
RFE: Virt-v2v should recognize partition names like
’/dev/mapper/rhel boot--73--75--123-root’ in related keys option
https://bugzilla.redhat.com/1910039
virt‐dib doesn’t work with newer diskimage‐builder version on RHEL8
SEE ALSO
http://libguestfs.org/
AUTHORS
Jürgen Hötzel
Laszlo Ersek
Richard W.M. Jones
virt-v2v-release-notes - virt-v2v release notes for 2.4
DESCRIPTION
These are the release notes for virt-v2v 2.4. This describes the major
changes since 2.2.
Virt-v2v 2.4.0 was released on 5 January 2024.
New features
New --block-driver option which can be used to choose to install either
virtio‐blk or virtio‐scsi drivers (Andrey Drobyshev).
The virt-v2v --key option now recognizes LVM names like
/dev/mapper/rhel_bootp--73--75--123-root (Laszlo Ersek).
The --key option also supports a new --key all:... selector to try the
same key on all devices.
Feature removed
Support for RHEL 3 conversions has been removed.
Other fixes
Conversions now set the "host-model" CPU in the output metadata, except
where the source hypervisor overrides this. The exception is -o qemu
mode which uses -cpu host. (Thanks Ming Xie, Laszlo Ersek, Dr. David
Alan Gilbert, Daniel Berrangé)
virt-v2v will now look for bootloader configuration in
/boot/grub/grub.cfg for UEFI guests (Andrey Drobyshev).
Invoke pnputil (if available) to install drivers, fixing some Windows
conversions (Andrey Drobyshev).
Skip SELinux relabelling if the guest has disabled SELinux (Roman
Kagan).
Several output modes now generate metadata to indicate whether the
guest requires the RTC to be set to UTC (Linux) or localtime (most
Windows). For example with -o libvirt this generates
<clock offset="utc|localtime"/>. (Thanks Lee Garrett, Laszlo Ersek)
-i ova mode is now less strict about parsing the manifest file, which
helps when converting some non‐conforming OVA files.
Input modes using -it ssh now use the correct quoting (thanks Bill
Sanders, Laszlo Ersek).
-i vmx mode now rejects VMDK files explicitly, reducing a source of
user confusion (thanks Ming Xie).
Multiple fixes to -o kubevirt mode. Also implement -oo compressed for
this mode. (Thanks Xiaodai Wang, Ming Xie)
-o libvirt mode now supports Rocky Linux (thanks Ming Xie).
-o openstack documentation for cloud configurations fixed (thanks Ming
Xie).
-o rhv‐upload mode has an improved error when the -os parameter is
invalid or missing (thanks Junqin Zhou).
Build changes
Support for OCaml 5, and OCaml ≥ 4.07 is now the minimum (thanks
Guillaume Munch‐Maccagnoni, Jerry James, Josh Berdine, Jürgen Hötzel,
Vincent Laviron).
Fix several tests so they can handle the case where the operating
system does not support btrfs or NTFS, instead of failing (Laszlo
Ersek).
Fix compatibility issues with libxml2 2.12.
Internals
Fix an off‐by‐one error which caused very rare crashes in virt-v2v.
Bugs fixed
https://bugzilla.redhat.com/2182024
improve UX when running as root and we can’t chown v2v tmpdir or
socks
https://bugzilla.redhat.com/2175703
virt-v2v failed to inspect RHEL9.2 guest due to kernel‐core /
kernel‐modules‐core subpackage split
https://bugzilla.redhat.com/2172075
Modify virt-v2v-output-openstack man page to add cloud.yaml related
information
https://bugzilla.redhat.com/2168506
RFE: Virt-v2v should recognize partition names like
’/dev/mapper/rhel boot--73--75--123-root’ in related keys option
https://bugzilla.redhat.com/2168082
win11/2022 failed to start into OS after converting to local
libvirt via virt-v2v on AMD EPYC‐Milan CPU model host
https://bugzilla.redhat.com/2166619
kernel panic when booting into OS with rocky9 guest converted by
v2v to local libvirt
https://bugzilla.redhat.com/2166618
There is virt-v2v: warning: unknown guest operating system: linux
rocky 9.1 x86_64 when convert rocky guests to local libvirt
https://bugzilla.redhat.com/2162444
Enable ’--oo compressed’ for -o kubevirt
https://bugzilla.redhat.com/2162332
-o kubevirt mode must rename guest to comply with KubeVirt
requirements: metadata.name: Invalid value:
"esx8.0-rhel8.8-x86_64": a lowercase RFC 1123 subdomain must
consist of lower case alphanumeric characters, ’-’ or ’.’, and must
start and end with an a
https://bugzilla.redhat.com/1986386
Improve error message when converting to rhv using the wrong data
domain name which has a specific character
SEE ALSO
virt-v2v(1).
AUTHORS
Authors of virt-v2v 2.4:
Andrey Drobyshev
Emilio Herrera
grimst
HATAYAMA Daisuke
Jan Kuparinen
Jürgen Hötzel
Laszlo Ersek
Pavel Borecki
Piotr Drąg
Richard W.M. Jones
Roman Kagan
Temuri Doghonadze
Yuri Chornoivan
COPYRIGHT
Copyright (C) 2009-2024 Red Hat Inc.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines. Supports shell scripting,
bindings from many languages. http://libguestfs.org
6 months, 3 weeks
- 1
- 0