May 2022 - Libguestfs - libguestfs List Archives

[PATCH libguestfs] build: When parsing distro from /etc/os-release, try $ID_LIKE first
by Richard W.M. Jones 23 May '22

23 May '22

The current code for working out the distro uses the ID entry from /etc/os-release, and then we map those strings into a smaller set of values (basically, what package manager to use). However it was suggested that we should try ID_LIKE first so that distros which act like other distros would work. On an Arch Linux 32 system: ID=arch32 ID_LIKE=arch See-also: https://github.com/libguestfs/libguestfs/issues/81 Thanks: S D Rausty --- m4/guestfs-appliance.m4 | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/m4/guestfs-appliance.m4 b/m4/guestfs-appliance.m4 index 9e443f151d..4e63ef4356 100644 --- a/m4/guestfs-appliance.m4 +++ b/m4/guestfs-appliance.m4 @@ -102,8 +102,16 @@ AC_ARG_WITH([distro], AC_MSG_RESULT([$DISTRO (manually specified)]) ],[ if test -f /etc/os-release; then - ( . /etc/os-release && echo $ID | tr '@<:@:lower:@:>@' '@<:@:upper:@:>@' ) >&AS_MESSAGE_LOG_FD - DISTRO="`. /etc/os-release && echo $ID | tr '@<:@:lower:@:>@' '@<:@:upper:@:>@'`" + echo "/etc/os-release:" >&AS_MESSAGE_LOG_FD + cat /etc/os-release >&AS_MESSAGE_LOG_FD + DISTRO="$( + . /etc/os-release + if test -n "$ID_LIKE"; then + echo $ID_LIKE | tr '@<:@:lower:@:>@' '@<:@:upper:@:>@' + else + echo $ID | tr '@<:@:lower:@:>@' '@<:@:upper:@:>@' + fi + )" AS_CASE([$DISTRO], [FEDORA | RHEL | CENTOS | ALMALINUX | CLOUDLINUX | ROCKY], [DISTRO=REDHAT], @@ -116,6 +124,7 @@ AC_ARG_WITH([distro], fi ] ) +AC_SUBST([DISTRO]) AM_CONDITIONAL([HAVE_RPM], [AS_CASE([$DISTRO], [REDHAT | SUSE | OPENMANDRIVA | MAGEIA ], [true], [*], [false])]) @@ -125,7 +134,6 @@ AM_CONDITIONAL([HAVE_DPKG], AM_CONDITIONAL([HAVE_PACMAN], [AS_CASE([$DISTRO], [ARCHLINUX | FRUGALWARE | ARTIX], [true], [*], [false])]) -AC_SUBST([DISTRO]) dnl Add extra packages to the appliance. AC_ARG_WITH([extra-packages], -- 2.35.1

1 1

[v2v PATCH 0/2] document percent encoding in ssh URIs in more detail
by Laszlo Ersek 19 May '22

19 May '22

https://bugzilla.redhat.com/show_bug.cgi?id=1938954 Determining the ssh:// URI (for -i vmx -it ssh) is not intuitive if the guest name includes characters outside of the portable filename character set. Expand the "VMX: Construct the SSH URI" section of the documentation. Thanks, Laszlo Laszlo Ersek (2): docs/*.pod: strip trailing space characters -i vmx -it ssh: document percent encoding in ssh URIs in more detail docs/virt-v2v-hacking.pod | 2 +- docs/virt-v2v-input-vmware.pod | 29 ++++++++++++++------ docs/virt-v2v.pod | 24 ++++++++-------- 3 files changed, 34 insertions(+), 21 deletions(-) base-commit: e06cf5b5dcbfd3f0a798eaf75c8778502c9e3bc6 -- 2.19.1.3.g30247aa5d201

2 8

[libguestfs PATCH] guestfs.pod: document encrypted RBD disk limitation
by Laszlo Ersek 19 May '22

19 May '22

Under "REMOTE STORAGE", the "NETWORK BLOCK DEVICE" section already documents some limitations. Turns out we need to describe a quirky exception for accessing encrypted RBD disks, too. Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2033247 Signed-off-by: Laszlo Ersek <lersek(a)redhat.com> --- lib/guestfs.pod | 33 ++++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/lib/guestfs.pod b/lib/guestfs.pod index b04c28d62750..1ad44e7c2878 100644 --- a/lib/guestfs.pod +++ b/lib/guestfs.pod @@ -679,6 +679,39 @@ servers. The server string is documented in L</guestfs_add_drive_opts>. The C<username> and C<secret> parameters are also optional, and if not given, then no authentication will be used. +An encrypted RBD disk -- I<directly> opening which would require the +C<username> and C<secret> parameters -- cannot be accessed if the +following conditions all hold: + +=over 4 + +=item * + +the L<backend|/BACKEND> is libvirt, + +=item * + +the image specified by the C<filename> parameter is different from the +encrypted RBD disk, + +=item * + +the image specified by the C<filename> parameter has L<qcow2 +format|/COMMON VIRTUAL DISK IMAGE FORMATS>, + +=item * + +the encrypted RBD disk is specified as a backing file at some level in +the qcow2 backing chain. + +=back + +This limitation is due to libvirt's (justified) separate handling of +disks vs. secrets. When the RBD username and secret are provided inside +a qcow2 backing file specification, libvirt does not construct an +ephemeral secret object from those, for Ceph authentication. Refer to +L<https://bugzilla.redhat.com/2033247>. + =head3 FTP, HTTP AND TFTP Libguestfs can access remote disks over FTP, FTPS, HTTP, HTTPS base-commit: 8a111cb82a3fcd7d98e428de57ceb048628e0051 -- 2.19.1.3.g30247aa5d201

2 3

[PATCH v2] docs: Add extra permission needed for non-admin download with VMware 7
by Richard W.M. Jones 19 May '22

19 May '22

From: Ming Xie <mxie(a)redhat.com> Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1817050 --- docs/virt-v2v-input-vmware.pod | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/docs/virt-v2v-input-vmware.pod b/docs/virt-v2v-input-vmware.pod index ab2d28e41f..bccf0f7490 100644 --- a/docs/virt-v2v-input-vmware.pod +++ b/docs/virt-v2v-input-vmware.pod @@ -559,8 +559,9 @@ write to libvirt or any other supported target. Instead of using the vCenter Administrator role, you can create a custom non-administrator role to perform the conversion. You will -however need to give it a minimum set of permissions as follows -(using VMware vCenter 6.5): +however need enable the following permissions (or as many as are +available, older versions of VMware were missing some of these +settings): =over 4 @@ -585,6 +586,7 @@ Enable (check) the following objects: Provisioning: - Allow disk access - Allow read-only disk access + - Allow virtual machine download Cryptographic operations: - Decrypt -- 2.35.1

2 2

ovirt VM image to BM
by Guilherme De Oliveira Santos 19 May '22

19 May '22

Greetings masters, I got pointed to you guys as experts on smtg I'm struggling with. I'm trying to move an ovirt vm raw image to a bm machine and though I could do it successfully using dd (got able to see and work with the partitions and the data fine), I couldn't boot the disk. It may be an issue with drivers (like the virtio drivers), but idk, and I'm wondering if someone has done smtg similar or could help somehow with the process. Really appreciate any answer on that, thanks! Gui

3 6

[PATCH] docs: Add extra permission needed for non-admin download with VMware 7
by Richard W.M. Jones 19 May '22

19 May '22

From: Ming Xie <mxie(a)redhat.com> Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1817050 --- docs/virt-v2v-input-vmware.pod | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/virt-v2v-input-vmware.pod b/docs/virt-v2v-input-vmware.pod index ab2d28e41f..60cff93994 100644 --- a/docs/virt-v2v-input-vmware.pod +++ b/docs/virt-v2v-input-vmware.pod @@ -585,6 +585,7 @@ Enable (check) the following objects: Provisioning: - Allow disk access - Allow read-only disk access + - Allow virtual machine download Cryptographic operations: - Decrypt -- 2.35.1

2 2

[PATCH] git: Add 'git-publish' config file
by Kashyap Chamarthy 18 May '22

18 May '22

The `git-publish`[1] tool is a wrapper around `git-format-patch` and `git-send-email`. It's a handy tool that automates some of the tedious aspects of manual patch submission: - Submitting a patch to the list (with a small config in place) is as simple as `git publish` - On next revisions, it automatically increments version numbers - It auto-copies the list of To: and Cc: from your previous iteration - It lets you preview/edit emails before submission - You can also use standard `git-format-patch` and `git-send-email` options with `git publish` - You can send pull requests with `git publish --pull-request` - It also provides custom hooks ... and more[2] [1] https://github.com/stefanha/git-publish [2] https://github.com/stefanha/git-publish/blob/master/git-publish.pod Signed-off-by: Kashyap Chamarthy <kchamart(a)redhat.com> --- .gitpublish | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 .gitpublish diff --git a/.gitpublish b/.gitpublish new file mode 100644 index 000000000..9775dd231 --- /dev/null +++ b/.gitpublish @@ -0,0 +1,3 @@ +[gitpublishprofile "default"] +base = master +to = libguestfs(a)redhat.com -- 2.35.1

2 1

[PATCH] website: Remove .git from 'git clone' URL
by Kashyap Chamarthy 18 May '22

18 May '22

GitHub dropped[1] support for .git protocol, so cloing with "git://" will fail. Use "https://" instead. [1] https://github.blog/2021-09-01-improving-git-protocol-security-github/ Signed-off-by: Kashyap Chamarthy <kchamart(a)redhat.com> --- website/index.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/website/index.html.in b/website/index.html.in index 7453129d6..5644243c0 100644 --- a/website/index.html.in +++ b/website/index.html.in @@ -174,7 +174,7 @@ For testers: <h2>Git repository</h2> <pre> -git clone <a href="https://github.com/libguestfs/libguestfs">git://github.com/libguestfs/libguestfs.git</a> +git clone <a href="https://github.com/libguestfs/libguestfs">https://github.com/libguestfs/libguestfs</a> </pre> </div> -- 2.35.1

1 1

[PATCH] git: Add 'git-publish' config file
by Kashyap Chamarthy 18 May '22

18 May '22

The `git-publish`[1] tool is a wrapper around `git-format-patch` and `git-send-email`. It's a handy tool that automates some of the tedious aspects of manual patch submission: - Submitting a patch to the list (with a small config in place) is as simple as `git publish` - On next revisions, it automatically increments version numbers - It auto-copies the list of To: and Cc: from your previous iteration - It lets you preview/edit emails before submission - You can also use standard `git-format-patch` and `git-send-email` options with `git publish` - You can send pull requests with `git publish --pull-request` - It also provides custom hooks ... and more[2] [1] https://github.com/stefanha/git-publish [2] https://github.com/stefanha/git-publish/blob/master/git-publish.pod Signed-off-by: Kashyap Chamarthy <kchamart(a)redhat.com> Signed-off-by: Kashyap Chamarthy <kchamart(a)redhat.com> --- .gitpublish | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 .gitpublish diff --git a/.gitpublish b/.gitpublish new file mode 100644 index 00000000..9775dd23 --- /dev/null +++ b/.gitpublish @@ -0,0 +1,3 @@ +[gitpublishprofile "default"] +base = master +to = libguestfs(a)redhat.com -- 2.35.1

1 0

[PATCH nbdkit] s3: Only run the tests if boto3 is installed
by Richard W.M. Jones 17 May '22

17 May '22

ERROR: S3 (unittest.loader._FailedTest) ---------------------------------------------------------------------- ImportError: Failed to import test module: S3 Traceback (most recent call last): File "/usr/lib64/python3.10/unittest/loader.py", line 154, in loadTestsFromName module = __import__(module_name) File "/home/rjones/d/nbdkit/plugins/S3/S3.py", line 41, in <module> import boto3 ModuleNotFoundError: No module named 'boto3' Reported-by: Laszlo Ersek Fixes: commit 5130c43bc1f9 --- tests/test-S3-unit.sh | 1 + tests/test-S3.sh | 1 + 2 files changed, 2 insertions(+) diff --git a/tests/test-S3-unit.sh b/tests/test-S3-unit.sh index 6b6adf02..8a32dd4c 100755 --- a/tests/test-S3-unit.sh +++ b/tests/test-S3-unit.sh @@ -37,6 +37,7 @@ set -x requires $PYTHON --version requires $PYTHON -c 'import unittest' +requires $PYTHON -c 'import boto3' # Python has proven very difficult to valgrind, therefore it is disabled. if [ "$NBDKIT_VALGRIND" = "1" ]; then diff --git a/tests/test-S3.sh b/tests/test-S3.sh index de94751e..e51ef2ac 100755 --- a/tests/test-S3.sh +++ b/tests/test-S3.sh @@ -36,6 +36,7 @@ set -x requires hexdump --version requires $PYTHON --version +requires $PYTHON -c 'import boto3' requires nbdcopy --version requires_plugin python -- 2.35.1

3 6