March 2018 - Libguestfs - libguestfs List Archives

Re: [Libguestfs] virt-v2v 1.38 fails to convert .vmx VM: setfiles ... Multiple same specifications for /.*.
by Richard W.M. Jones 12 Mar '18

12 Mar '18

On Mon, Mar 12, 2018 at 08:25:58AM +0000, Зиновик Игорь Анатольевич wrote: > Hello, Richard. > > Did you managed to find root cause of the problem that I reported last week? I didn't have a chance to look at this. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 100 libraries supported. http://fedoraproject.org/wiki/MinGW

1 0

[PATCH v5 0/4] v2v: Add -o rhv-upload output mode.
by Richard W.M. Jones 11 Mar '18

11 Mar '18

Mainly minor fixes and code cleanups over the v4 patch. There are still several problems with this patch, but it is in a reviewable state, especially the Python code. Rich.

4 11

febootstrap: no ext2 root device found
by Steve Keller Savvco 08 Mar '18

08 Mar '18

Hello- I've recently upgraded from OEL 6.4 to OEL 6.8. Infiniband Hardware installed on the server prevents me from upgrading the OS version any higher. Kernel Version: Oracle Linux Server Red Hat Compatible Kernel (2.6.32-642.el6.x86_64) Since the upgrade, there have been problems with libguestfs-tools hanging, then timing out. I'd like to use the newest version of libguestfs-tools if possible, but all versions above "1.16.34-2.el6" that have been tested time out with the same error. Running "libguestfs-test-tool" with Kernel (2.6.32-642.el6.x86_64); the results are as follows: libguestfs-tools.x86_64 1:1.16.34-2.el6 public_ol6_u4_base (works) libguestfs-tools.x86_64 1:1.20.11-2.el6 public_ol6_u5_base (times out with error "febootstrap: no ext2 root device found") libguestfs-tools.x86_64 1:1.20.11-17.el6 public_ol6_u8_base (times out with error "febootstrap: no ext2 root device found") libguestfs-tools.x86_64 1:1.20.11-20.el6 public_ol6_latest (times out with error "febootstrap: no ext2 root device found") I can provide the output of the tests if required. Any suggestions are greatly appreciated! Thanks.

2 4

[PATCH nbdkit 0/2] tests: Minor reworking of tests.
by Richard W.M. Jones 07 Mar '18

07 Mar '18

Small reworking of tests to remove $QEMU_IO, making that consistent with other test tools, and to test IPv6 connections.

2 6

[PATCH nbdkit] Fix --dump-plugin on perl, python and ruby plugins.
by Richard W.M. Jones 07 Mar '18

07 Mar '18

Previously doing: nbdkit python --dump-plugin would segfault since the script was not loaded. It was possible to work around this using: nbdkit python test.py --dump-plugin assuming that you had a Python script to use. Change the code so that the original command (without the script name) doesn't segfault. --- plugins/perl/perl.c | 2 +- plugins/python/python.c | 2 +- plugins/ruby/ruby.c | 4 +--- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/plugins/perl/perl.c b/plugins/perl/perl.c index 80e5695..8d35b85 100644 --- a/plugins/perl/perl.c +++ b/plugins/perl/perl.c @@ -169,7 +169,7 @@ perl_dump_plugin (void) { dSP; - if (callback_defined ("dump_plugin")) { + if (script && callback_defined ("dump_plugin")) { ENTER; SAVETMPS; PUSHMARK (SP); diff --git a/plugins/python/python.c b/plugins/python/python.c index b105e53..83a32ea 100644 --- a/plugins/python/python.c +++ b/plugins/python/python.c @@ -155,7 +155,7 @@ py_dump_plugin (void) PyObject *fn; PyObject *r; - if (callback_defined ("dump_plugin", &fn)) { + if (script && callback_defined ("dump_plugin", &fn)) { PyErr_Clear (); r = PyObject_CallObject (fn, NULL); diff --git a/plugins/ruby/ruby.c b/plugins/ruby/ruby.c index 6b0285f..aa57f65 100644 --- a/plugins/ruby/ruby.c +++ b/plugins/ruby/ruby.c @@ -168,10 +168,8 @@ plugin_rb_unload (void) static void plugin_rb_dump_plugin (void) { - if (!script) { - nbdkit_error ("the first parameter must be script=/path/to/ruby/script.rb"); + if (!script) return; - } assert (code != NULL); -- 2.13.2

2 1

[nbdkit PATCH] tests: Make parallel tests work at 512-byte granularity
by Eric Blake 05 Mar '18

05 Mar '18

qemu-io 2.12 will be changing its default alignment to unknown servers so that it does read-modify-write for anything less than 512 bytes. If we implement NBD_OPT_GO, then we can keep qemu-io using 1-byte alignment; but until then, this breaks our parallel tests when using 1-byte alignment because they end up with more delays than expected (thanks to the read-modify-write). Revamp the tests to not rely on sub-sector alignment, which works with both qemu-io 2.11 and 2.12, and fixes a TODO item. Signed-off-by: Eric Blake <eblake(a)redhat.com> --- I'm pushing this one now. TODO | 5 ----- tests/test-parallel-file.sh | 45 ++++++++++++++++++++++++--------------------- tests/test-parallel-nbd.sh | 43 +++++++++++++++++++++++-------------------- 3 files changed, 47 insertions(+), 46 deletions(-) diff --git a/TODO b/TODO index 37baed2..4731b1e 100644 --- a/TODO +++ b/TODO @@ -40,11 +40,6 @@ General ideas for improvements ones like offset) can fail to initialize if they can't guarantee strict alignment and don't want to deal with bounce buffers. -* Tests written that use qemu-io need to be audited: qemu-io 2.11 - would send 1-byte requests to any server, but 2.12 will tighten it - to do read-modify-write to 512 bytes unless the server supports - NBD_OPT_GO. - Suggestions for plugins ----------------------- diff --git a/tests/test-parallel-file.sh b/tests/test-parallel-file.sh index ed1f99c..8c307af 100755 --- a/tests/test-parallel-file.sh +++ b/tests/test-parallel-file.sh @@ -1,6 +1,6 @@ #!/bin/bash - # nbdkit -# Copyright (C) 2017 Red Hat Inc. +# Copyright (C) 2017-2018 Red Hat Inc. # All rights reserved. # # Redistribution and use in source and binary forms, with or without @@ -31,14 +31,17 @@ # OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF # SUCH DAMAGE. -# Makefile sets $QEMU_IO and builds file-data, but it's also nice if the -# script runs again standalone afterwards for diagnosing any failures -test -f file-data || { echo "Missing file-data"; exit 77; } +# Makefile sets $QEMU_IO, but it's also nice if the script runs again +# standalone afterwards for diagnosing any failures : ${QEMU_IO=qemu-io} -# Sanity check that qemu-io can issue parallel requests -$QEMU_IO -f raw -c "aio_write -P 2 1 1" -c "aio_read -P 1 0 1" -c aio_flush \ - file-data || { echo "'$QEMU_IO' can't drive parallel requests"; exit 77; } +trap 'rm -f test-parallel-file.data test-parallel-file.out' 0 1 2 3 15 + +# Populate file, and sanity check that qemu-io can issue parallel requests +printf '%1024s' . > test-parallel-file.data +$QEMU_IO -f raw -c "aio_write -P 1 0 512" -c "aio_write -P 2 512 512" \ + -c aio_flush test-parallel-file.data || + { echo "'$QEMU_IO' can't drive parallel requests"; exit 77; } # Set up the file plugin to delay both reads and writes (for a good chance # that parallel requests are in flight), and with writes longer than reads @@ -46,25 +49,25 @@ $QEMU_IO -f raw -c "aio_write -P 2 1 1" -c "aio_read -P 1 0 1" -c aio_flush \ # may have spurious failures under heavy loads on the test machine, where # tuning the delays may help. -trap 'rm -f test-parallel-file.out' 0 1 2 3 15 - # With --threads=1, the write should complete first because it was issued first -nbdkit -v -t 1 -U - --filter=delay file file=file-data wdelay=2 rdelay=1 --run ' - $QEMU_IO -f raw -c "aio_write -P 2 1 1" -c "aio_read -P 1 0 1" -c aio_flush $nbd -' | tee test-parallel-file.out -if test "$(grep '1/1' test-parallel-file.out)" != \ -"wrote 1/1 bytes at offset 1 -read 1/1 bytes at offset 0"; then +nbdkit -v -t 1 -U - --filter=delay file file=test-parallel-file.data \ + wdelay=2 rdelay=1 --run '$QEMU_IO -f raw -c "aio_write -P 2 512 512" \ + -c "aio_read -P 1 0 512" -c aio_flush $nbd' | + tee test-parallel-file.out +if test "$(grep '512/512' test-parallel-file.out)" != \ +"wrote 512/512 bytes at offset 512 +read 512/512 bytes at offset 0"; then exit 1 fi # With default --threads, the faster read should complete first -nbdkit -v -U - --filter=delay file file=file-data wdelay=2 rdelay=1 --run ' - $QEMU_IO -f raw -c "aio_write -P 2 1 1" -c "aio_read -P 1 0 1" -c aio_flush $nbd -' | tee test-parallel-file.out -if test "$(grep '1/1' test-parallel-file.out)" != \ -"read 1/1 bytes at offset 0 -wrote 1/1 bytes at offset 1"; then +nbdkit -v -U - --filter=delay file file=test-parallel-file.data \ + wdelay=2 rdelay=1 --run '$QEMU_IO -f raw -c "aio_write -P 2 512 512" \ + -c "aio_read -P 1 0 512" -c aio_flush $nbd' | + tee test-parallel-file.out +if test "$(grep '512/512' test-parallel-file.out)" != \ +"read 512/512 bytes at offset 0 +wrote 512/512 bytes at offset 512"; then exit 1 fi diff --git a/tests/test-parallel-nbd.sh b/tests/test-parallel-nbd.sh index 244faf6..fda0b7d 100755 --- a/tests/test-parallel-nbd.sh +++ b/tests/test-parallel-nbd.sh @@ -1,6 +1,6 @@ #!/bin/bash - # nbdkit -# Copyright (C) 2017 Red Hat Inc. +# Copyright (C) 2017-2018 Red Hat Inc. # All rights reserved. # # Redistribution and use in source and binary forms, with or without @@ -31,49 +31,52 @@ # OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF # SUCH DAMAGE. -# Makefile sets $QEMU_IO and builds file-data, but it's also nice if the -# script runs again standalone afterwards for diagnosing any failures -test -f file-data || { echo "Missing file-data"; exit 77; } +# Makefile sets $QEMU_IO, but it's also nice if the # script runs again +# standalone afterwards for diagnosing any failures : ${QEMU_IO=qemu-io} -# Sanity check that qemu-io can issue parallel requests -$QEMU_IO -f raw -c "aio_write -P 2 1 1" -c "aio_read -P 1 0 1" -c aio_flush \ - file-data || { echo "'$QEMU_IO' can't drive parallel requests"; exit 77; } - # We require --exit-with-parent to work ( nbdkit --exit-with-parent --help ) >/dev/null 2>&1 || { echo "Missing --exit-with-parent support"; exit 77; } +files='test-parallel-nbd.out test-parallel-nbd.sock test-parallel-nbd.data' +trap 'rm -f $files' 0 1 2 3 15 + +# Populate file, and sanity check that qemu-io can issue parallel requests +printf '%1024s' . > test-parallel-nbd.data +$QEMU_IO -f raw -c "aio_write -P 1 0 512" -c "aio_write -P 2 512 512" \ + -c aio_flush test-parallel-nbd.data || + { echo "'$QEMU_IO' can't drive parallel requests"; exit 77; } + # Set up the file plugin to delay both reads and writes (for a good chance # that parallel requests are in flight), and with writes longer than reads # (to more easily detect if out-of-order completion happens). This test # may have spurious failures under heavy loads on the test machine, where # tuning the delays may help. -trap 'rm -f test-parallel-nbd.out test-parallel-nbd.sock' 0 1 2 3 15 ( rm -f test-parallel-nbd.sock nbdkit --exit-with-parent -v -U test-parallel-nbd.sock \ --filter=delay \ - file file=file-data wdelay=2 rdelay=1 & + file file=test-parallel-nbd.data wdelay=2 rdelay=1 & # With --threads=1, the write should complete first because it was issued first nbdkit -v -t 1 -U - nbd socket=test-parallel-nbd.sock --run ' - $QEMU_IO -f raw -c "aio_write -P 2 1 1" -c "aio_read -P 1 0 1" -c aio_flush $nbd -' | tee test-parallel-nbd.out -if test "$(grep '1/1' test-parallel-nbd.out)" != \ -"wrote 1/1 bytes at offset 1 -read 1/1 bytes at offset 0"; then + $QEMU_IO -f raw -c "aio_write -P 2 512 512" -c "aio_read -P 1 0 512" \ + -c aio_flush $nbd' | tee test-parallel-nbd.out +if test "$(grep '512/512' test-parallel-nbd.out)" != \ +"wrote 512/512 bytes at offset 512 +read 512/512 bytes at offset 0"; then exit 1 fi # With default --threads, the faster read should complete first nbdkit -v -U - nbd socket=test-parallel-nbd.sock --run ' - $QEMU_IO -f raw -c "aio_write -P 2 1 1" -c "aio_read -P 1 0 1" -c aio_flush $nbd -' | tee test-parallel-nbd.out -if test "$(grep '1/1' test-parallel-nbd.out)" != \ -"read 1/1 bytes at offset 0 -wrote 1/1 bytes at offset 1"; then + $QEMU_IO -f raw -c "aio_write -P 2 512 512" -c "aio_read -P 1 0 512" \ + -c aio_flush $nbd' | tee test-parallel-nbd.out +if test "$(grep '512/512' test-parallel-nbd.out)" != \ +"read 512/512 bytes at offset 0 +wrote 512/512 bytes at offset 512"; then exit 1 fi -- 2.14.3

2 1

[PATCH v3 0/6] v2v: Add -o rhv-upload output mode.
by Richard W.M. Jones 02 Mar '18

02 Mar '18

v2 -> v3: - Lots of code cleanups. - Documentation. However this is still spooling the file into a temporary before the upload. It turns out that fixing this is going to require a small change to qemu. Rich.

3 9