October 2015 - Libguestfs - libguestfs List Archives

Help, it's not working!
by Pezhman Sheini 13 Oct '15

13 Oct '15

pj@Xen:~$ libguestfs-test-tool ************************************************************ * IMPORTANT NOTICE * * When reporting bugs, include the COMPLETE, UNEDITED * output below in your bug report. * ************************************************************ PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games SELinux: sh: 1: getenforce: not found guestfs_get_append: (null) guestfs_get_backend: direct guestfs_get_autosync: 1 guestfs_get_cachedir: /var/tmp guestfs_get_direct: 0 guestfs_get_hv: /usr/bin/qemu-system-x86_64 guestfs_get_memsize: 500 guestfs_get_network: 0 guestfs_get_path: /usr/lib/guestfs guestfs_get_pgroup: 0 guestfs_get_program: libguestfs-test-tool guestfs_get_recovery_proc: 1 guestfs_get_selinux: 0 guestfs_get_smp: 1 guestfs_get_tmpdir: /tmp guestfs_get_trace: 0 guestfs_get_verbose: 1 host_cpu: x86_64 Launching appliance, timeout set to 600 seconds. libguestfs: launch: program=libguestfs-test-tool libguestfs: launch: version=1.24.5 libguestfs: launch: backend registered: unix libguestfs: launch: backend registered: uml libguestfs: launch: backend registered: libvirt libguestfs: launch: backend registered: direct libguestfs: launch: backend=direct libguestfs: launch: tmpdir=/tmp/libguestfssuzvm0 libguestfs: launch: umask=0002 libguestfs: launch: euid=1000 libguestfs: command: run: /usr/bin/supermin-helper libguestfs: command: run: \ --verbose libguestfs: command: run: \ -f checksum libguestfs: command: run: \ --host-cpu x86_64 libguestfs: command: run: \ /usr/lib/guestfs/supermin.d supermin helper [00000ms] whitelist = (not specified) supermin helper [00000ms] host_cpu = x86_64 supermin helper [00000ms] dtb_wildcard = (not specified) supermin helper [00000ms] inputs: supermin helper [00000ms] inputs[0] = /usr/lib/guestfs/supermin.d supermin helper [00000ms] outputs: supermin helper [00000ms] kernel = (none) supermin helper [00000ms] dtb = (none) supermin helper [00000ms] initrd = (none) supermin helper [00000ms] appliance = (none) checking modpath /lib/modules/3.13.0-32-generic is a directory picked kernel vmlinuz-3.13.0-32-generic supermin helper [00000ms] finished creating kernel supermin helper [00000ms] visiting /usr/lib/guestfs/supermin.d supermin helper [00000ms] visiting /usr/lib/guestfs/supermin.d/base.img supermin helper [00000ms] visiting /usr/lib/guestfs/supermin.d/daemon.img.gz supermin helper [00000ms] visiting /usr/lib/guestfs/supermin.d/hostfiles supermin helper [00015ms] visiting /usr/lib/guestfs/supermin.d/init.img supermin helper [00015ms] visiting /usr/lib/guestfs/supermin.d/udev-rules.img supermin helper [00015ms] adding kernel modules supermin helper [00057ms] finished creating appliance libguestfs: checksum of existing appliance: 9d4e855e8fa224f3474fc197fde081809ed5af124eaf3ef6011218d061c4f3f2 libguestfs: [00061ms] begin building supermin appliance libguestfs: [00061ms] run supermin-helper libguestfs: command: run: /usr/bin/supermin-helper libguestfs: command: run: \ --verbose libguestfs: command: run: \ --copy-kernel libguestfs: command: run: \ -f ext2 libguestfs: command: run: \ --host-cpu x86_64 libguestfs: command: run: \ /usr/lib/guestfs/supermin.d libguestfs: command: run: \ --output-kernel /var/tmp/guestfs.kjUXmY/kernel libguestfs: command: run: \ --output-initrd /var/tmp/guestfs.kjUXmY/initrd libguestfs: command: run: \ --output-appliance /var/tmp/guestfs.kjUXmY/root supermin helper [00000ms] whitelist = (not specified) supermin helper [00000ms] host_cpu = x86_64 supermin helper [00000ms] dtb_wildcard = (not specified) supermin helper [00000ms] inputs: supermin helper [00000ms] inputs[0] = /usr/lib/guestfs/supermin.d supermin helper [00000ms] outputs: supermin helper [00000ms] kernel = /var/tmp/guestfs.kjUXmY/kernel supermin helper [00000ms] dtb = (none) supermin helper [00000ms] initrd = /var/tmp/guestfs.kjUXmY/initrd supermin helper [00000ms] appliance = /var/tmp/guestfs.kjUXmY/root checking modpath /lib/modules/3.13.0-32-generic is a directory picked kernel vmlinuz-3.13.0-32-generic /usr/bin/supermin-helper: open: /boot/vmlinuz-3.13.0-32-generic: Permission denied libguestfs: error: /usr/bin/supermin-helper exited with error status 1, see debug messages above libguestfs: command: run: rm libguestfs: command: run: \ -rf /var/tmp/guestfs.kjUXmY libguestfs-test-tool: failed to launch appliance libguestfs: closing guestfs handle 0xe00150 (state 0) libguestfs: command: run: rm libguestfs: command: run: \ -rf /tmp/libguestfssuzvm0

2 1

[PATCH v2] rpm: Choose providers better (RHBZ#1266918).
by Richard W.M. Jones 13 Oct '15

13 Oct '15

This is v2 of the 4/4 patch from the original series. Changes: - memoize the function this time - check packages are installed using rpm_package_of_string However I didn't combine the two case together, because the code is a bit simpler with them separate. Rich.

1 1

[PATCH 0/4] rpm: Choose providers better (RHBZ#1266918).
by Richard W.M. Jones 13 Oct '15

13 Oct '15

Fix for https://bugzilla.redhat.com/show_bug.cgi?id=1266918

2 6

[PATCH 0/4] v2v: Use libvirt-supplied <vmware:datacenterpath> if available.
by Richard W.M. Jones 09 Oct '15

09 Oct '15

See earlier thread on libvir-list: https://www.redhat.com/archives/libvir-list/2015-September/thread.html#00201 Libvirt >= 1.2.20 supplies the correct dcPath parameter. If it is available in the libvirt XML, use it, otherwise fall back to the old method of trying to guess it from the vpx:// path. Patches 1, 2 and 4 are just refactoring around this change. Rich.

1 4

[PATCH] inspect: Don't free uninitialized string.
by Richard W.M. Jones 09 Oct '15

09 Oct '15

libguestfs: trace: v2v: read_lines "/etc/os-release" [...] libguestfs: trace: v2v: read_lines = ["NAME=Fedora", "VERSION="20 (Heisenbug)"", "ID=fedora", "VERSION_ID=20", "PRETTY_NAME="Fedora 20 (Heisenbug)"", "ANSI_COLOR="0;34"", "CPE_NAME="cpe:/o:fedoraproject:fedora:20"", "HOME_URL="https://fedoraproject.org/"", "BUG_REPORT_URL="https://bugzilla.redhat.com/"", "REDHAT_BUGZILLA_PRODUCT="Fedora"", "REDHAT_BUGZILLA_PRODUCT_VERSION=20", "REDHAT_SUPPORT_PRODUCT="Fedora"", "REDHAT_SUPPORT_PRODUCT_VERSION=20"] At this point libguestfs segfaulted. It seems as if 'major' is not used here, so don't try to free it. This fixes commit 32d19e3289bc259901f77398703f16cf6eabd510. --- src/inspect-fs-unix.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/inspect-fs-unix.c b/src/inspect-fs-unix.c index cda1b5d..3d19276 100644 --- a/src/inspect-fs-unix.c +++ b/src/inspect-fs-unix.c @@ -232,7 +232,6 @@ parse_os_release (guestfs_h *g, struct inspect_fs *fs, const char *filename) char buf[value_len + 1]; snprintf (buf, sizeof buf, "%*s", (int) value_len, value); major_version = guestfs_int_parse_unsigned_int (g, buf); - free (major); /* Handle cases where VERSION_ID is not a number. */ if (major_version != -1) minor_version = 0; -- 2.5.0

2 1

[PATCH] v2v: Add xpath_int64 functions, and use them to read memory values.
by Richard W.M. Jones 08 Oct '15

08 Oct '15

On 32 bit platforms, reading the memory values can cause some numbers to be read as negative numbers. Fix this by treating memory values as 64 bit integers throughout the parsing and calculation. --- v2v/input_libvirtxml.ml | 7 ++++--- v2v/input_ova.ml | 7 ++++--- v2v/utils.ml | 15 +++++++++++++++ 3 files changed, 23 insertions(+), 6 deletions(-) diff --git a/v2v/input_libvirtxml.ml b/v2v/input_libvirtxml.ml index 976848f..d8c6215 100644 --- a/v2v/input_libvirtxml.ml +++ b/v2v/input_libvirtxml.ml @@ -54,7 +54,8 @@ let parse_libvirt_xml ?conn xml = let xpathctx = Xml.xpath_new_context doc in let xpath_string = xpath_string xpathctx and xpath_int = xpath_int xpathctx - and xpath_int_default = xpath_int_default xpathctx in + and xpath_int_default = xpath_int_default xpathctx + and xpath_int64_default = xpath_int64_default xpathctx in let hypervisor = match xpath_string "/domain/@type" with @@ -66,8 +67,8 @@ let parse_libvirt_xml ?conn xml = | None | Some "" -> error (f_"in the libvirt XML metadata, <name> is missing or empty") | Some s -> s in - let memory = xpath_int_default "/domain/memory/text()" (1024 * 1024) in - let memory = Int64.of_int memory *^ 1024L in + let memory = xpath_int64_default "/domain/memory/text()" (1024L *^ 1024L) in + let memory = memory *^ 1024L in let vcpu = xpath_int_default "/domain/vcpu/text()" 1 in let features = diff --git a/v2v/input_ova.ml b/v2v/input_ova.ml index a758e94..cd26160 100644 --- a/v2v/input_ova.ml +++ b/v2v/input_ova.ml @@ -183,7 +183,8 @@ object let xpath_string = xpath_string xpathctx and xpath_int = xpath_int xpathctx and xpath_string_default = xpath_string_default xpathctx - and xpath_int_default = xpath_int_default xpathctx in + and xpath_int_default = xpath_int_default xpathctx + and xpath_int64_default = xpath_int64_default xpathctx in (* Search for vm name. *) let name = @@ -193,8 +194,8 @@ object | Some name -> name in (* Search for memory. *) - let memory = xpath_int_default "/ovf:Envelope/ovf:VirtualSystem/ovf:VirtualHardwareSection/ovf:Item[rasd:ResourceType/text()=4]/rasd:VirtualQuantity/text()" (1024 * 1024) in - let memory = Int64.of_int (memory * 1024 * 1024) in + let memory = xpath_int64_default "/ovf:Envelope/ovf:VirtualSystem/ovf:VirtualHardwareSection/ovf:Item[rasd:ResourceType/text()=4]/rasd:VirtualQuantity/text()" (1024L *^ 1024L) in + let memory = memory *^ 1024L *^ 1024L in (* Search for number of vCPUs. *) let vcpu = xpath_int_default "/ovf:Envelope/ovf:VirtualSystem/ovf:VirtualHardwareSection/ovf:Item[rasd:ResourceType/text()=3]/rasd:VirtualQuantity/text()" 1 in diff --git a/v2v/utils.ml b/v2v/utils.ml index ee956be..2998d90 100644 --- a/v2v/utils.ml +++ b/v2v/utils.ml @@ -79,6 +79,17 @@ let xpath_int xpathctx expr = error (f_"expecting XML expression to return an integer (expression: %s, matching string: %s)") expr str ) +let xpath_int64 xpathctx expr = + let obj = Xml.xpath_eval_expression xpathctx expr in + if Xml.xpathobj_nr_nodes obj < 1 then None + else ( + let node = Xml.xpathobj_node obj 0 in + let str = Xml.node_as_string node in + try Some (Int64.of_string str) + with Failure "int_of_string" -> + error (f_"expecting XML expression to return an integer (expression: %s, matching string: %s)") + expr str + ) (* Parse an xpath expression and return a string/int; if the expression * doesn't match, return the default. @@ -91,6 +102,10 @@ let xpath_int_default xpathctx expr default = match xpath_int xpathctx expr with | None -> default | Some i -> i +let xpath_int64_default xpathctx expr default = + match xpath_int64 xpathctx expr with + | None -> default + | Some i -> i external drive_name : int -> string = "v2v_utils_drive_name" external drive_index : string -> int = "v2v_utils_drive_index" -- 2.5.0

1 0

[PATCH 0/6] v2v: assorted improvements to tests for windows
by Roman Kagan 08 Oct '15

08 Oct '15

This series makes several enhancements to tests for v2v conversion of Windows guests. Specifically, it - adds a number of files which imitate the stuff that is supposed to be present on the host when the actual conversion is performed, but may not be there when the tests are run. This includes certain tools and virtio drivers - fixes the test for windows conversion to actually check that the guest filesystem contains the expected files and directories upon conversion - adds a test for the case when virtio windows drivers are provied on an iso image - fixes a bogus failure case in a utility function which triggered on the newly added fake virio windows driver directory. Roman Kagan (6): tests: use fake rhsrvany.exe tests: add fake rhev-apt.exe v2v:test:win: actually check the eventual layout tests: use fake virtio-win drivers v2v:utils: ignore files w/o extension add test for v2v with virtio-win drivers on iso Makefile.am | 1 + configure.ac | 1 + p2v/test-virt-p2v-pxe.sh | 10 ++--- p2v/test-virt-p2v.sh | 9 ++--- tests/fake-virt-tools/rhev-apt.exe | 1 + tests/fake-virt-tools/rhsrvany.exe | 1 + tests/fake-virtio-win/.gitignore | 1 + tests/fake-virtio-win/Makefile.am | 34 ++++++++++++++++ tests/fake-virtio-win/drivers/i386/Win7/netkvm.cat | 1 + tests/fake-virtio-win/drivers/i386/Win7/netkvm.inf | 1 + tests/fake-virtio-win/drivers/i386/Win7/netkvm.sys | 1 + tests/fake-virtio-win/drivers/i386/Win7/qxl.cat | 1 + tests/fake-virtio-win/drivers/i386/Win7/qxl.inf | 1 + tests/fake-virtio-win/drivers/i386/Win7/qxl.sys | 1 + .../fake-virtio-win/drivers/i386/Win7/vioscsi.cat | 1 + .../fake-virtio-win/drivers/i386/Win7/vioscsi.inf | 1 + .../fake-virtio-win/drivers/i386/Win7/vioscsi.sys | 1 + .../fake-virtio-win/drivers/i386/Win7/viostor.cat | 1 + .../fake-virtio-win/drivers/i386/Win7/viostor.inf | 1 + .../fake-virtio-win/drivers/i386/Win7/viostor.sys | 1 + tests/regressions/rhbz1232192.sh | 7 +--- v2v/Makefile.am | 1 + v2v/test-v2v-cdrom.sh | 7 +--- v2v/test-v2v-i-disk.sh | 7 +--- v2v/test-v2v-i-ova-formats.sh | 7 +--- v2v/test-v2v-i-ova-gz.sh | 7 +--- v2v/test-v2v-i-ova-two-disks.sh | 8 ++-- v2v/test-v2v-i-ova.sh | 8 ++-- v2v/test-v2v-networks-and-bridges.sh | 6 +-- v2v/test-v2v-no-copy.sh | 6 +-- v2v/test-v2v-o-glance.sh | 6 +-- v2v/test-v2v-o-libvirt.sh | 6 +-- v2v/test-v2v-o-null.sh | 6 +-- v2v/test-v2v-o-qemu.sh | 6 +-- v2v/test-v2v-o-rhev.sh | 6 +-- v2v/test-v2v-o-vdsm-options.sh | 6 +-- v2v/test-v2v-oa-option.sh | 6 +-- v2v/test-v2v-of-option.sh | 6 +-- v2v/test-v2v-on-option.sh | 6 +-- v2v/test-v2v-sound.sh | 6 +-- ...ws-conversion.sh => test-v2v-virtio-win-iso.sh} | 45 ++++++++++++++-------- v2v/test-v2v-windows-conversion.sh | 35 +++++++++++------ v2v/utils.ml | 5 +-- 43 files changed, 140 insertions(+), 139 deletions(-) create mode 100644 tests/fake-virt-tools/rhev-apt.exe create mode 100644 tests/fake-virt-tools/rhsrvany.exe create mode 100644 tests/fake-virtio-win/.gitignore create mode 100644 tests/fake-virtio-win/Makefile.am create mode 100644 tests/fake-virtio-win/drivers/i386/Win7/netkvm.cat create mode 100644 tests/fake-virtio-win/drivers/i386/Win7/netkvm.inf create mode 100644 tests/fake-virtio-win/drivers/i386/Win7/netkvm.sys create mode 100644 tests/fake-virtio-win/drivers/i386/Win7/qxl.cat create mode 100644 tests/fake-virtio-win/drivers/i386/Win7/qxl.inf create mode 100644 tests/fake-virtio-win/drivers/i386/Win7/qxl.sys create mode 100644 tests/fake-virtio-win/drivers/i386/Win7/vioscsi.cat create mode 100644 tests/fake-virtio-win/drivers/i386/Win7/vioscsi.inf create mode 100644 tests/fake-virtio-win/drivers/i386/Win7/vioscsi.sys create mode 100644 tests/fake-virtio-win/drivers/i386/Win7/viostor.cat create mode 100644 tests/fake-virtio-win/drivers/i386/Win7/viostor.inf create mode 100644 tests/fake-virtio-win/drivers/i386/Win7/viostor.sys copy v2v/{test-v2v-windows-conversion.sh => test-v2v-virtio-win-iso.sh} (65%) -- 2.4.3

3 34

fetching virt-p2v GUI on fedora 21
by M R, Chengappa (NFV BU) 08 Oct '15

08 Oct '15

We need one simple deployment of converting a given server with some OS converted to a Virtual Machine. i.e. -> to have a simple Linux/fedora machine and install apache or any web server for testing or any application for that matter - the purpose here is to see if this application works after the conversion to a virtual machine -> Convert P2V using the tools. -> Start virtual machine and see if works. We have our conversion server in place, but we would like to know how could we initiate virt-p2v GUI from my physical server, we have difficulties understanding this -> When you start virt-p2v, you'll see a graphical configuration dialog that walks you through connection to the conversion server, asks for the password, which local hard disks you want to convert, and other things like the name of the guest to create and the number of virtual CPUs to give it. How do we start virt-p2v on a fedora 21 Further, we see this: [root@localhost ~]# yum install virt-p2v Loaded plugins: langpacks updates/21/x86_64/metalink | 14 kB 00:00:00 updates | 4.7 kB 00:00:00 No package virt-p2v available. Error: Nothing to do [root@localhost ~]# virt-p2v --help bash: virt-p2v: command not found... Could you please help us with the steps in getting up the GUI Sorry if this is very basic and if it seems to be a stupid question, apologize upfront as we are taking a stab @ it for the first time... Awaiting for response patiently.... Thanks & Regards, Chengappa

2 1

[PATCH 0/2] New APIs: set-identifier, get-identifier
by Richard W.M. Jones 07 Oct '15

07 Oct '15

This is very useful for debugging multithreaded programs. Rich.

1 2

[PATCH 0/4] ocaml: Allow Guestfs.t handle to be garbage collected.
by Richard W.M. Jones 07 Oct '15

07 Oct '15

Allow Guestfs.t handle to be garbage collected, and add a regression test.

2 7