October 2010 - Libguestfs - libguestfs List Archives

[REVIEW ONLY] Ensure atomic creation of a cached appliance
by Matthew Booth 04 Oct '10

04 Oct '10

Cached appliances are discovered by their predictable path. Previously we were creating a cached appliance directly in this predictable path. This had at least 2 undesirable effects: * Interrupting appliance creation would leave a corrupt appliance * 2 processes could simultaneously attempt to create the same appliance, causing corruption. This patch causes the cached appliance to be created in a temporary directory, and then renamed to the predictable path. As rename is an atomic operation, this makes the whole creation atomic. This patch also changes the predictable path to have a prefix of 'guestfs.'. This will make it simpler for system administrators to clean up old cached appliances. Note that this version of the patch doesn't cleanup the temporary directory of a guestfs process which didn't win an appliance creation race. --- regressions/test-launch-race.pl | 53 +++++++++++++++++++++++++++++++++++++++ src/appliance.c | 49 ++++++++++++++++++++++++++--------- 2 files changed, 89 insertions(+), 13 deletions(-) create mode 100755 regressions/test-launch-race.pl

1 0

[PATCH] Ignore cscope.out
by Matthew Booth 04 Oct '10

04 Oct '10

--- .gitignore | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)

1 0

[PATCH 1/2] Add -u and -g options to febootstrap-supermin-helper
by Matthew Booth 04 Oct '10

04 Oct '10

Bash automatically resets euid to uid when it executes. This can mean that the effective user id of a program at the point it calls febootstrap-supermin-helper can be lost if any part of execution chain involved bash. This in turn can result in: * the generation of an incorrect checksum, which contains the uid. * the generation of supermin files with differing owners The -u and -g options allow the caller to pass in an explicit user and group to run as. These will be used when generating a checksum. Additionally, febootstrap-supermin-helper will set(u|g)id as appropriate if they are given for non-checksum output. This ensures all generated files will have the correct ownership, regardless of how they are created. --- helper/checksum.c | 2 +- helper/helper.h | 2 + helper/main.c | 145 ++++++++++++++++++++++++++++++++++++++++++++++------- 3 files changed, 130 insertions(+), 19 deletions(-)

2 4

[PATCH 0/4] Fixes for virt-resize
by Richard W.M. Jones 01 Oct '10

01 Oct '10

Fixes for both of these bugs: https://bugzilla.redhat.com/show_bug.cgi?id=633096 virt-resize calculates block device size incorrectly, doesn't work with qcow2 target https://bugzilla.redhat.com/show_bug.cgi?id=633766 virt-resize --shrink fails I'm still doing testing on these, but the patches seem good enough to review. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://et.redhat.com/~rjones/virt-top

1 7

[PATCH] Call febootstrap-supermin-helper using the new -u and -g options
by Matthew Booth 01 Oct '10

01 Oct '10

Use febootstrap-supermin-helper's new -u and -g command line options to setuid, rather than doing it in libguestfs. This resolves an issue with the generation of the cached appliance checksum. The checksum was being generated by a call to febootstrap-supermin-helper through popen(). Unfortunately, a bash misfeature meant that euid would be reset to uid, and the checksum was generated for uid, not euid. When virt-v2v is writing to a RHEV target, uid == 0 and euid == 36, which resulted in a cached appliance being created for root with permissions for uid 36. --- src/appliance.c | 51 +++++++++++++++++++++------------------------------ 1 files changed, 21 insertions(+), 30 deletions(-)

1 0

[PATCH 1/2] New internal function guestfs___print_timestamped_argv
by Matthew Booth 01 Oct '10

01 Oct '10

This function generalises the existing print_cmdline used to output the qemu command line to output any given command line, and exports it to other modules. It also adds a timestamp to the old print_cmdline output for consistency with guestfs___print_timestamped_message. --- src/guestfs-internal.h | 1 + src/launch.c | 48 ++++++++++++++++++++++++------------------------ 2 files changed, 25 insertions(+), 24 deletions(-)

1 1

[FEBOOTSTRAP] Add gnulib as a submodule
by Matthew Booth 01 Oct '10

01 Oct '10

--- .gitmodules | 3 +++ autogen.sh | 4 +--- gnulib | 1 + 3 files changed, 5 insertions(+), 3 deletions(-) create mode 100644 .gitmodules create mode 160000 gnulib

1 0

[PATCH] fish: Fix glob command (RHBZ#635969).
by Richard W.M. Jones 01 Oct '10

01 Oct '10

Note this bug was very confusing because glob works when you use the -x (trace) option, so when you try to trace the commands being run the bug "disappears". Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://et.redhat.com/~rjones/virt-top

1 1