Re: [Libguestfs] [libnbd PATCH v2 8/8] python: Make nbd.Buffer lighter-weight

On Mon, Jun 06, 2022 at 09:08:33PM -0500, Eric Blake wrote: > Instead of storing a PyCapsule in _o and repeatedly doing lookups to > dereference a stored malloc'd pointer, it is easier to just directly > store a Python buffer-like object as _o. Track initialization via > ._init: absent for nbd.Buffer(int), present for > nbd.Buffer.from_bytearray or after we have forced initialization due > to aio_pread or .to_bytearray. At this point, we are still copying in > and out of .{from,to}_bytearray, but we are getting closer to reducing > the number of copies. The sheer size in reduced lines of code is a > testament to the ease of doing things closer to Python, rather than > hidden behind unpacking a PyCapsule layer. >

Looks like a nice simplification! Reviewed-by: Richard W.M. Jones <rjones(a)redhat.com&gt;