Re: [Libguestfs] [PATCH] v2v: -o rhv-upload: Optimize http request sending
On Mon, Jun 18, 2018 at 09:58:23PM +0300, Nir Soffer wrote:
On Mon, Jun 18, 2018 at 9:23 PM Richard W.M. Jones
<rjones(a)redhat.com>
wrote:
> On Mon, Jun 18, 2018 at 08:55:13PM +0300, Nir Soffer wrote:
> > On Mon, Jun 18, 2018 at 1:37 PM Richard W.M. Jones <rjones(a)redhat.com>
> > wrote:
> >
> > > On Thu, Jun 14, 2018 at 09:24:48PM +0300, Nir Soffer wrote:
> > > > On Thu, Jun 14, 2018 at 9:16 PM Nir Soffer <nirsof(a)gmail.com>
wrote:
> > > > > + headers = {"Content-Type":
"application/json",
> > > > > + "Content-Length", str(len(buf))}
> > >
> > > There were a few Python syntax errors such as this one. They
> > > can be found by running:
> > >
> > > make -C v2v check TESTS=test-v2v-python-syntax.sh
> > >
> >
> > Cool. Why not include this in "make check"?
>
> It is! That command is just if you want to run the single test.
>
Strange, I did run "make check" but it did not fail on checking
the rhv plugin. It was failing because of unralted c-api test.
Maybe make aborted before running the v2v tests?
Right, it runs the tests in subdirectories in order and aborts at the
first subdirectory which fails (this is just how make / automake
works, it's nothing special to libguestfs):
$ make print-subdirs | fold -72 -s
common/mlstdutils generator tests/qemu test-data gnulib/lib
gnulib/tests common/errnostring common/protocol common/qemuopts
common/utils common/structs lib docs examples po common/mlutils
common/mlaugeas common/mlpcre daemon tests/daemon appliance tests/c-api
tests/tmpdirs tests/protocol tests/events tests/parallel tests/create
tests/disks tests/discard tests/mountable tests/network tests/lvm
tests/luks tests/md tests/selinux tests/relabel tests/ntfs tests/btrfs
tests/xfs tests/charsets tests/xml tests/mount-local tests/9p
tests/rsync tests/bigdirs tests/disk-labels tests/hotplug tests/nbd
tests/http tests/syslinux tests/journal tests/relative-paths
tests/gdisk tests/regressions tests/tsk tests/yara common/edit
common/options common/parallel common/progress common/visit
common/windows test-tool fish align cat diff df edit format inspector
make-fs rescue common/miniexpect p2v bash perl perl/examples ocaml
ocaml/examples python python/examples ruby ruby/examples java
java/examples php erlang erlang/examples lua lua/examples gobject
csharp common/mlgettext common/mlprogress common/mlvisit common/mlxml
common/mltools customize builder builder/templates get-kernel resize
sparsify sysprep v2v v2v/test-harness dib tools fuse
utils/boot-analysis utils/boot-benchmark utils/max-disks
utils/qemu-boot utils/qemu-speed-test po-docs
If you want it to continue after the first failure (this also applies
to every automake-using program) then do:
make check -k
less `find -name test-suite.log | xargs grep -l ^FAIL:`
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-builder quickly builds VMs from scratch
http://libguestfs.org/virt-builder.1.html