Re: [Libguestfs] [PATCH 01/11] v2v: Move have_selinux to utils.
On Monday, April 8, 2019 1:10:07 PM CEST Richard W.M. Jones wrote:
This is not quite a neutral refactoring, because it means we now run
the getenforce command every time virt-v2v starts up. However it's a
trivial command that reads a single /sys file and it can't fail even
if the command is missing or on platforms that know nothing about
SELinux.
---
Alternative approach to retain the current behaviour:
- add the proposed "have_selinux" statement as function in Utils, maybe
with a better name such as "is_selinux_enforcing"
- assigning to the have_selinux variables the result of
is_selinux_enforcing ()
I see this patch was already pushed though ...
--
Pino Toscano
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)