Re: [Libguestfs] nbdinfo default output [was: [libnbd PATCH v2 6/6] info: Tolerate missing size]
On 9/22/23 16:14, Eric Blake wrote:
On Fri, Sep 22, 2023 at 09:03:53AM -0500, Eric Blake wrote:
>>> $ ./run nbdinfo nbd://localhost
>>> protocol: newstyle-fixed without TLS, using extended packets
>>> ...
>>> block_size_maximum: 33554432
For the human-readable output, should we also be using human_size() on
the block_size_* values? I'd find:
block_size_minimum: 1
block_size_preferred: 4096 (4K)
block_size_maximum: 33554432 (32M)
somewhat easier to read.
Right, that looks very convenient!
Thanks!
Laszlo
I don't know if the JSON version would need
to output that extra information, though. But that's a question
independent of this patch series.