March 2018 - Libguestfs - Libguestfs List Archives

[PATCH] v2v: -o rhv-upload: Support zero requests.

by Richard W.M. Jones

Only compile tested. I'm keeping this as a separate patch for the moment until the relevant change on the oVirt side goes upstream. Rich.

7 years

2
2
0 / 0

[PATCH v2 0/5] Add --print-target with machine-readable version.

by Richard W.M. Jones

This adds --print-target. In addition, v2 provides a machine-readable version (in JSON format). All of the record -> JSON boilerplate in this patch could be eliminated if we moved the baseline to OCaml 4.02. Rich.

7 years

2
7
0 / 0

Re: [Libguestfs] virt-v2v 1.38 fails to convert .vmx VM: setfiles ... Multiple same specifications for /.*.

by Richard W.M. Jones

On Mon, Mar 19, 2018 at 02:21:24PM +0000, Зиновик Игорь Анатольевич wrote: > > -----Original Message----- > > From: Richard W.M. Jones [mailto:rjones@redhat.com] > > Sent: Monday, March 19, 2018 3:27 PM > > To: Зиновик Игорь Анатольевич <ZinovikIA(a)nspk.ru> > > Cc: libguestfs(a)redhat.com > > Subject: Re: [Libguestfs] virt-v2v 1.38 fails to convert .vmx VM: setfiles ... > > Multiple same specifications for /.*. > > > > On Tue, Mar 06, 2018 at 09:31:33AM +0000, Зиновик Игорь Анатольевич > > wrote: > > > > Multiple same specifications for /.*. > > ... > > > > > setfiles: > > > > > /sysroot/etc/selinux/targeted/contexts/files/file_contexts: > > > > > Multiple > > > > same specifications for /.*. > > > > My idea for reproducing this was: > > > > (1) Download your file_contexts file. > > > > (2) virt-builder fedora-27 \ > > --upload file_contexts:/etc/selinux/targeted/contexts/files/file_contexts \ > > --selinux-relabel > > > > > > However I wasn't able to reproduce it (with policycoreutils-2.7-15.fc29.x86_64). > > Also I don't see multiple ‘/.*’ > > lines in the file_contexts file. > > > > So I don't know. > > > > But it's still my opinion that it is a bug in policycoreutils. > > Thanks for investigation, Richard. Is it somehow possible to disable `setfiles' invocation > during virt-v2v conversion run? E.g. via environment variable? You can do --no-selinux-relabel, but that disables relabelling completely, which may mean that your VM won't boot. Have you tried making edits to the file_contexts file to work out exactly which part setfiles is complaining about? That may give some clues about a better workaround. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into KVM guests. http://libguestfs.org/virt-v2v

7 years

2
1
0 / 0

virt-v2v 1.38 fails to convert .vmx VM: setfiles ... Multiple same specifications for /.*.

by Зиновик Игорь Анатольевич

Hello. I'm trying to convert VMware based virtual machines (CentOS 7.2) and output them into oVirt. virt-v2v fails with following error: setfiles: /sysroot/etc/selinux/targeted/contexts/files/file_contexts: Multiple same specifications for /.*. File `file_contexts' looks same like in recent CentOS 7.4. My conversion server is Fedora 28 (Rawhide), since it contains virt-v2v 1.38. virt-v2v -v -x output is attached. Настоящее сообщение, направленное по электронной почте, и любые вложения - это корреспонденция, содержащая информацию, доступ к которой ограничен в соответствии с законодательством Российской Федерации и которая предназначена только для использования уполномоченными АО «НСПК» получателями сообщения (уполномоченными лицами). Если Вы не являетесь уполномоченным лицом или Вам не известно, являетесь ли Вы таким уполномоченным получателем сообщения от АО «НСПК», то уведомляем, что любое раскрытие, распространение или копирование этого сообщения влечет за собой установленную законом ответственность. Если Вы не являетесь уполномоченным получателем сообщения, просим Вас незамедлительно информировать об этом отправителя и удалить полученное сообщение из системы. This e-mail message together with any attachments hereto contains confidential information and is intended for recipients authorized by NSPK only. Any disclosure, distribution or copying of this message entails liability established by law. If you are not an authorized recipient, please immediately inform the sender and delete this message from your information system.

7 years

2
5
0 / 0

Re: [Libguestfs] [libvirt] [PATCH tck] Relabel SELinux when customizing virt-builder image

by Laine Stump

On 02/06/2018 10:53 AM, Pino Toscano wrote: > On Tuesday, 6 February 2018 16:40:04 CET Daniel P. Berrangé wrote: >> When you tell virt-builder to install extra RPMs, this potentially >> looses the SELinux labelling that Anaconda had originally setup. Thus we >> must tell virt-builder to enable SELinux relabelling. >> >> Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> >> --- >> lib/Sys/Virt/TCK.pm | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/lib/Sys/Virt/TCK.pm b/lib/Sys/Virt/TCK.pm >> index e9da8d2..b39f578 100644 >> --- a/lib/Sys/Virt/TCK.pm >> +++ b/lib/Sys/Virt/TCK.pm >> @@ -405,7 +405,7 @@ sub create_virt_builder_disk { >> } >> >> print "# running virt-builder $osname\n"; >> - system "virt-builder", "--install", "dsniff", "--root-password", "password:$password", "--output", $target, $osname; >> + system "virt-builder", "--install", "dsniff", "--selinux-relabel", "--root-password", "password:$password", "--output", $target, $osname; >> >> die "cannot run virt-builder: $?" if $? != 0; > > Reviewed-by: Pino Toscano <ptoscano(a)redhat.com> > This change works, but since the original image came from virt-builder, and virt-builder knows enough about the image to know that it should install packages with dnf (or yum or apt-get or whatever is appropriate for any given image), it should also have enough info available to determine on its own that the selinux labels need to be redone. Especially since the Fedora images provided by virt-builder have selinux set to enforcing, I think the default behavior in this case should be for virt-builder to relabel. This patch fixes the problem for libvirt-tck, but I can imagine that this same problem will be revisited time after time on IRC and the libguestfs mailing list (once the user takes the obligatory troubleshooting trip to discover the source of the problem). In this case the initial symptom was "a guest that was never logged into by a human was failing an automated test". There were several steps from there to "dhcpc was failing to get an IP address due to bad selinux labels", and then learning via IRC that the labels were incorrect because extra packages are installed with the image mounted on the libguestfs appliance, which runs with selinux disabled. What is preventing virt-builder from automatically making a correct determination about whether or not relabeling must be done?

7 years

2
2
0 / 0

guestfs_list_filesystems: skip block devices which cannot hold file system

by Mykola Ivanets

Initial discussion is here: https://www.redhat.com/archives/libguestfs/2018-January/msg00188.html. v2 was posted here: https://www.redhat.com/archives/libguestfs/2018-January/msg00246.html. v3 comparing to v2 is just a rebase with slightly changed commits comments.

7 years

3
12
0 / 0

[PATCH 0/2] v2v: Add --print-target to display overlay and target information.

by Richard W.M. Jones

RHV was connecting to the VMware source in order to find out the virtual disk size of the source disk(s), duplicating logic that virt-v2v already provides. This makes that information available using a new ‘virt-v2v --print-target option’. Note in order to get all the information, this has to actually perform the conversion step, so it takes 30 seconds or so before we reach the point where the information gets printed. We could also add a more easily parsable version of this data ... Rich.

7 years

2
4
0 / 0

[PATCH v4 0/3] v2v: Add -o rhv-upload output mode.

by Richard W.M. Jones

Previous versions: v3: https://www.redhat.com/archives/libguestfs/2018-March/msg00000.html v2: https://www.redhat.com/archives/libguestfs/2018-February/msg00177.html v1: https://www.redhat.com/archives/libguestfs/2018-February/msg00139.html This completely rethinks the approach taken by the previous patches. Instead of trying to involve qemu's curl driver, this uses a small Python 3 nbdkit plugin to interface between qemu and the oVirt server. The data path is: qemu-img convert -------> nbdkit -------> oVirt imageio nbd https There are two Python scripts included. One is the nbdkit plugin. The other creates the VM. As with the previous patches, these scripts get embeded in virt-v2v at compile time, so effectively there is no API contract between virt-v2v & the Python code. With this patch series I am able to (mostly) successfully convert VMs from local disk to oVirt 4.2, with full end-to-end streaming. There is some room for optimization -- in particular uploads are currently rather slow because we rely on qemu-img batching small requests into large ones which it doesn't do well, and instead the nbdkit plugin could batch small writes into larger ones. Also I noticed (but only one time) that very long transfers would cause the oVirt ticket to expire, even though we were writing the whole time. There are still a few unresolved issues (see patch 3/3) so this is not quite ready to go upstream yet, but can still be reviewed. Patches 1 & 2 are the same as posted before. I did not yet test qcow2 uploads. Those are "interestingly" different because qcow2 will require us to read from the remote oVirt server as well as just stream/write to it. The pread method for that is written but has not been tested. Rich.

7 years

3
23
0 / 0

proposal for feature to add global setting for libguestfs emulation type

by Raghu Toppur

The man page for libguestfs says: export LIBGUESTFS_BACKEND_SETTINGS=force_tcg will force the direct and libvirt backends to use TCG (software emulation) instead of KVM (hardware accelerated virtualization). However, our application has many services (run by different users) which make use of libguestfs tools, and it is painful to have to set this environment variable for each script and service. One alternative seems to be to rebuild the libguestfs library with force_tcg baked in, but I need to support platforms. Is there one location I can specify this setting to force tcg? I would have thought that /etc/libguestfs-tools.conf might be the place, but that only allows a read_only attribute to be set. Thanks -- Raghu Toppur

7 years

2
1
0 / 0

[PATCH RHEL 7] RHEL 7: -o rhv-upload: Use Python 2 instead of Python

by Richard W.M. Jones

For interest only, here is the patch required to make -o rhv-upload work with Python 2 (for RHEL 7). I don't think we want this upstream. A couple of remarks: * It's supposed to be possible to add ‘coding: utf-8’ to the top of .py files to make Python 2 accept that the file is UTF-8 (otherwise it gives an error on loading). However I added this and it didn't appear to make any difference, I still had to replace the Unicode quotes with ASCII ones, so I don't know what's going on there. * The ‘byteify’ function is a bit of a hack, but required here because the Python 2 json library returns unicode objects where all the rest of the libraries are expecting str. Not needed in Python 3 of course. Rich.

7 years

1
1
0 / 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

Libguestfs March 2018